Skip to content

ctests: fix an integer conversion issue #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

daniloegea
Copy link
Contributor

The return type of netplan_netdef_get_output_filename() is signed size_t. The test was failing on armhf due to a cast issue:

[ ERROR ] --- 0xfffffffe != 0xfffffffffffffffe
[ LINE ] --- ../tests/ctests/test_netplan_misc.c:164: error: Failure!

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

The return type of netplan_netdef_get_output_filename() is signed
size_t. The test was failing on armhf due to a cast issue:

[  ERROR   ] --- 0xfffffffe != 0xfffffffffffffffe
[   LINE   ] --- ../tests/ctests/test_netplan_misc.c:164: error: Failure!
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@slyon slyon merged commit bc751e7 into canonical:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants