Skip to content

ctests: fix an integer conversion issue - #315

Merged
slyon merged 1 commit into
canonical:mainfrom
daniloegea:ctests_fixes
Jan 18, 2023
Merged

ctests: fix an integer conversion issue#315
slyon merged 1 commit into
canonical:mainfrom
daniloegea:ctests_fixes

Conversation

@daniloegea

Copy link
Copy Markdown
Contributor

The return type of netplan_netdef_get_output_filename() is signed size_t. The test was failing on armhf due to a cast issue:

[ ERROR ] --- 0xfffffffe != 0xfffffffffffffffe
[ LINE ] --- ../tests/ctests/test_netplan_misc.c:164: error: Failure!

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

The return type of netplan_netdef_get_output_filename() is signed
size_t. The test was failing on armhf due to a cast issue:

[  ERROR   ] --- 0xfffffffe != 0xfffffffffffffffe
[   LINE   ] --- ../tests/ctests/test_netplan_misc.c:164: error: Failure!

@slyon slyon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@slyon
slyon merged commit bc751e7 into canonical:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants