Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak action #321

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Memory leak action #321

merged 4 commits into from
Feb 1, 2023

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Jan 31, 2023

Description

Add an script that can be used to run the netplan binaries and check for memory issues and a github action to call this script.

I added it to a directory called "tools" because it can be useful during development.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

The script will simply build netplan with ASAN and call of the C unit
tests and the generator for every single file in the examples directory.
If something is leaking memory for example in the code paths executed
during the tests it will exit with error.
The generator was failing to processes some files.
The new action will call the script tools/run_asan.sh.
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm. Just one small nitpick inline, that we should fix before merging.

tools/run_asan.sh Outdated Show resolved Hide resolved
@daniloegea daniloegea requested a review from slyon February 1, 2023 16:22
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@slyon slyon merged commit 0109970 into canonical:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants