Memory leak action#321
Merged
Merged
Conversation
added 3 commits
January 31, 2023 19:35
The script will simply build netplan with ASAN and call of the C unit tests and the generator for every single file in the examples directory. If something is leaking memory for example in the code paths executed during the tests it will exit with error.
The generator was failing to processes some files.
The new action will call the script tools/run_asan.sh.
slyon
approved these changes
Feb 1, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thanks, lgtm. Just one small nitpick inline, that we should fix before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an script that can be used to run the netplan binaries and check for memory issues and a github action to call this script.
I added it to a directory called "tools" because it can be useful during development.
Checklist
make checksuccessfully.make check-coverage).