libnetplan: don't try to read from a NULL file #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build an error context for a file without a name (when using netplan set for example), the filename will be NULL. We are triggering some critical assertions from glib thanks to that:
In this cases the context will be meaningless:
Also, add G_DEBUG=fatal_criticals to the test environment so we'll segfault if we assert on a critical issue again.
It will change the error message for the command
netplan set --root-dir /tmp/fakeroot bridges.eth12.dhcp4=falsea
from:to:
Description
Checklist
make check
successfully.make check-coverage
).