[DPE-8005] Handle empty region #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (67.75%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1099 +/- ##
===========================================
- Coverage 67.81% 67.75% -0.06%
===========================================
Files 15 15
Lines 4129 4134 +5
Branches 606 608 +2
===========================================
+ Hits 2800 2801 +1
- Misses 1106 1108 +2
- Partials 223 225 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-8005-empty-region
branch
from
b4a82d3 to
34f7c4e
Compare
dragomirp
force-pushed
the
dpe-8005-empty-region
branch
from
34f7c4e to
0b0da68
Compare
dragomirp
commented
Sep 12, 2025
Comment on lines
+167
to
+177
| await backup_operations( | ||
| ops_test, | ||
| charm, | ||
| S3_INTEGRATOR_APP_NAME, | ||
| tls_certificates_app_name, | ||
| tls_config, | ||
| tls_channel, | ||
| cloud_credentials, | ||
| "ceph", | ||
| cloud_configs, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Copied from VM. The only difference is the order of backup_operations() args.
Member
There was a problem hiding this comment.
Thanks for porting this test!
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
marceloneppel
approved these changes
Sep 12, 2025
Comment on lines
+167
to
+177
| await backup_operations( | ||
| ops_test, | ||
| charm, | ||
| S3_INTEGRATOR_APP_NAME, | ||
| tls_certificates_app_name, | ||
| tls_config, | ||
| tls_channel, | ||
| cloud_credentials, | ||
| "ceph", | ||
| cloud_configs, | ||
| ) |
Member
There was a problem hiding this comment.
Thanks for porting this test!
taurus-forever
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of canonical/postgresql-operator#1117, canonical/postgresql-operator#1149 and canonical/postgresql-operator#1154 for 16/edge k8s:
Checklist