Skip to content

Conversation

@dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Sep 14, 2025

Port of canonical/postgresql-operator#1117, canonical/postgresql-operator#1149 and canonical/postgresql-operator#1154 for 14/edge k8s:

  • Handle empty region when creating backups
  • Handle invalid stanza name in Pgbackrest output (happens when no region is set in GCP) to block as failure to initialise stanza and not as foreign backup
  • Add ceph test

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp dragomirp added the bug Something isn't working as expected label Sep 14, 2025
@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Sep 14, 2025
@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (bee017f) to head (ec73e2f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/backups.py 76.19% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   73.27%   73.22%   -0.06%     
==========================================
  Files          15       15              
  Lines        3922     3929       +7     
  Branches      575      577       +2     
==========================================
+ Hits         2874     2877       +3     
- Misses        834      836       +2     
- Partials      214      216       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp marked this pull request as ready for review September 15, 2025 09:25
@dragomirp dragomirp requested review from a team, marceloneppel and taurus-forever and removed request for a team September 15, 2025 09:25
@dragomirp dragomirp merged commit d11c364 into main Sep 15, 2025
692 of 707 checks passed
@dragomirp dragomirp deleted the dpe-8005-empty-region-14 branch September 15, 2025 19:19
@shipperizer shipperizer mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants