-
Notifications
You must be signed in to change notification settings - Fork 27
juju tf/1.0 #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
juju tf/1.0 #1157
Conversation
0611654 to
1e7ff89
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (67.44%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1157 +/- ##
========================================
Coverage 67.44% 67.44%
========================================
Files 18 18
Lines 3947 3947
Branches 564 564
========================================
Hits 2662 2662
Misses 1112 1112
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e7ff89 to
98e7e06
Compare
98e7e06 to
d75e4f6
Compare
marceloneppel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
|
Hi, @shipperizer! Could you update your PR's branch with the latest changes from the |
|
will do |
d75e4f6 to
afe5901
Compare
Also modified the storage directives parameter to get it working with both 14 and 16 tracks