This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Debugtrace #225
Merged
Debugtrace #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
| } while (0) | ||
|
|
||
| /* Enable the tracer if the env variable is set or disable the tracer */ | ||
| void raft_tracer_maybe_enable(struct raft_tracer *tracer, bool enabled); |
There was a problem hiding this comment.
Nitpick: iiuc this is an internal function/symbol, so it should probably be named something like "TraceMaybeEnable" or similar (convention is CamelCase for internal symbols and snail_case for public ones).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at adding tracing to raft when
LIBRAFT_TRACEis set on startup. Will probably have to refine the messages a bit and also wire up the libuv tracing, but having these messages would already be helpful when debugging some cases.