extensions/kde-neon: use platform snap as plug name #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppd
force-pushed
the
kde-neon-plug-name
branch
from
921e3b4 to
6829cb9
Compare
Using the same plug name "kde-frameworks-5-plug" for all providers leads to problems when an application updates its base or changes its default provider because a new framework snap gets published for the same base. In that case, snapd will keep the old framework snap connected and will happily connect the new framework snap in addition to the old one. This breaks applications because they won't find the correct framework snap mounted at $SNAP/kf5. Prevent this by using the same strategy that the gnome extensions use: plug name = content snap name See https://forum.snapcraft.io/t/snap-accumulates-content-interface-connections-to-multiple-platform-snaps/27523/8
ppd
force-pushed
the
kde-neon-plug-name
branch
from
6829cb9 to
5b5d7fb
Compare
|
I also removed the manual connection in the spread test. It is a) not required any more because auto-connect has been granted, and b) the plug name is different now, so we'd have to change it anyway. |
4 tasks
sergiusens
approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #3596 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 278 278
Lines 19375 19375
=======================================
Hits 17680 17680
Misses 1695 1695
Continue to review full report at Codecov.
|
3 tasks
ppd
added a commit
to ppd/qelectrotech-source-mirror
that referenced
this pull request
Jan 13, 2022
Now that canonical/snapcraft#3596 has been released in snapcraft 6.0.1, drop the prompt that tells users to disconnect the old framework snap. Also drop --enable-experimental-extensions from CI because kde-neon has been declared stable for core20.
ppd
added a commit
to qelectrotech/qelectrotech-source-mirror
that referenced
this pull request
Jan 14, 2022
Now that canonical/snapcraft#3596 has been released in snapcraft 6.0.1, drop the prompt that tells users to disconnect the old framework snap. Also drop --enable-experimental-extensions from CI because kde-neon has been declared stable for core20.
ppd
added a commit
to ppd/qelectrotech-source-mirror
that referenced
this pull request
Jan 20, 2022
Now that canonical/snapcraft#3596 has been released in snapcraft 6.0.1, drop the prompt that tells users to disconnect the old framework snap. Also drop --enable-experimental-extensions from CI because kde-neon has been declared stable for core20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same plug name "kde-frameworks-5-plug"
for all providers leads to problems when an
application updates its base or changes its default
provider because a new framework snap gets published
for the same base.
In that case, snapd will keep the old framework snap
connected and will happily connect the new framework
snap in addition to the old one.
This breaks applications because they won't find the correct
framework snap mounted at $SNAP/kf5.
Prevent this by using the same strategy that the gnome
extensions use: plug name = content snap name
See https://forum.snapcraft.io/t/snap-accumulates-content-interface-connections-to-multiple-platform-snaps/27523/8
./runtests.sh static?./runtests.sh tests/unit/project_loader/extensions?I built a snap (anki-ppd) with this change and everything works as expected. Also CC @jriddell.
I'm not sure about the subsystem prefix; it seemed more complete than just "extensions".