osutils: deal with ENOENT in UserMaybeSudoUser() #11275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `sssd` package is installed on a Ubuntu system the
`TestUserMaybeSudoUser` test will fail because then `user.Lookup`
returns a generic error
```
user: lookup username guy: no such file or directory
```
because in the go layer the getpw{uid,nam}_r() returned ENOENT.
This is already reported upstream as
golang/go#40334
This commit works around this upstream issue by checking for
ENOENT on the error from user.Lookup(). It's not nice but the
best I could come up to to handle this case. On my 21.10 system
sssd is installed as part of `ubuntu-desktop-minimal`.
Codecov Report
@@ Coverage Diff @@
## master #11275 +/- ##
==========================================
- Coverage 78.36% 78.35% -0.01%
==========================================
Files 927 927
Lines 105700 105710 +10
==========================================
- Hits 82832 82830 -2
- Misses 17719 17728 +9
- Partials 5149 5152 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MiguelPires
reviewed
Jan 20, 2022
bboozzoo
approved these changes
Jan 21, 2022
…t() and simply code a little bit
mvo5
added
Squash-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
sssdpackage is installed on a Ubuntu system theTestUserMaybeSudoUsertest will fail because thenuser.Lookupreturns a generic error
because in the go layer the getpw{uid,nam}_r() returned ENOENT.
This is already reported upstream as
golang/go#40334
This commit works around this upstream issue by checking for
ENOENT on the error from user.Lookup(). It's not nice but the
best I could come up to to handle this case. On my 21.10 system
sssd is installed as part of
ubuntu-desktop-minimal.