autoinstall: adjust x-make-view-request behavior #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With autoinstall, a controller that was not interactive would decline outright to provide the response to GET queries, with the notion that the controller needed to be skipped. Limit this behavior to only when `x-make-view-request: yes` is set, which let's the client be able to get the real response, or the skip info, depending on need.
dbungert
force-pushed
the
make-view-request-fix
branch
from
18029ae
to
ec38ae9
Compare
mwhudson
approved these changes
Jan 24, 2023
|
|
||
| view_request_yes = await inst.get( | ||
| '/locale', headers={'x-make-view-request': 'yes'}) | ||
| self.assertIsNone(view_request_yes) |
There was a problem hiding this comment.
do you have any way to test the value of the x-skip header in the response?
There was a problem hiding this comment.
if the answer is "no" that's fine, having any tests >> having no tests!
There was a problem hiding this comment.
I debated doing so. I'll spend a little time on it and explore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With autoinstall, a controller that was not interactive would decline
outright to provide the response to GET queries, with the notion that the
controller needed to be skipped. Limit this behavior to only when
x-make-view-request: yesis set, which lets the client be able to getthe real response, or the skip info, depending on need.