This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Use YaruDialogTitleBar #1323
Merged
Use YaruDialogTitleBar #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
force-pushed
the
dialog-title-bar
branch
from
c8aa886
to
e458aa1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jpnurmi
force-pushed
the
dialog-title-bar
branch
from
8ce5c20
to
e458aa1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only makes the dialogs look nicer but also adds such behavior that could be considered a pre-requisite for replacing the native
HdyHeaderBarwithYaruWindowTitleBar(outside vs. inside the Flutter view, respectively).When a modal dialog is open, the entire Flutter view is covered by a modal barrier. This means that
YaruWindowTitleBaris not accessible underneath whenever a modal dialog is open.YaruDialogTitleBarsolves this by offering the usual top-level window actions (move by drag, right-click menu) via the dialog title bar. It feels a lot like a modal top-level dialog attached to and blocking its parent window.Ref: #670