Set the appropriate pocket in the security entry in sources list file with Deb822 format #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Mars <paul.mars@canonical.com>
…list Signed-off-by: Paul Mars <paul.mars@canonical.com>
|
That is a simple fix but I may have missed a corner case. Let me know if we should be more clever when generating this entry for the security pocket. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 16 16
Lines 3284 3284
=======================================
Hits 3096 3096
Misses 120 120
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sil2100
previously approved these changes
May 16, 2024
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the deb822 format, we add an entry for the security pocket with a specific mirror. This entry now correctly the
securitypocket.As a bonus, now a proper list of existing pockets is defined to make it easily usable and less error prone.