New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phpBB Debug] PHP Warning: in file [ROOT]/ext/canonknipser/viewexif/event/main_listener.php on line 136: Division by zero #18

Closed
bcurran3 opened this Issue Sep 24, 2017 · 15 comments

Comments

Projects
None yet
2 participants
@bcurran3

bcurran3 commented Sep 24, 2017

I see the error:
[phpBB Debug] PHP Warning: in file [ROOT]/ext/canonknipser/viewexif/event/main_listener.php on line 136: Division by zero
pop up now and then, not sure why. It doesn't seem to affect anything.

PHPBB 3.2.1 (happened in 3.2.0 as well), PHP 7, viewexif 1.03

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Sep 24, 2017

Owner

As this is related to the exif data of your image, can you post please post a problematic attachment in my testing area http://canonknipser.com/viewforum.php?f=11

I'll check it soon

Owner

canonknipser commented Sep 24, 2017

As this is related to the exif data of your image, can you post please post a problematic attachment in my testing area http://canonknipser.com/viewforum.php?f=11

I'll check it soon

@canonknipser canonknipser self-assigned this Sep 24, 2017

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Sep 24, 2017

Owner

Did some investigation:
I assume it happens because the behavior of "list" changed between php 5.x and 7.x - order of the parameters changed: http://php.net/manual/en/function.list.php
Will try to fix as soon as possible.
Because "list" is used on different positions in the code, i need a little time (and won't fix it in 1.0.3, but in 1.1.0 already in phpBB validation queue).

Owner

canonknipser commented Sep 24, 2017

Did some investigation:
I assume it happens because the behavior of "list" changed between php 5.x and 7.x - order of the parameters changed: http://php.net/manual/en/function.list.php
Will try to fix as soon as possible.
Because "list" is used on different positions in the code, i need a little time (and won't fix it in 1.0.3, but in 1.1.0 already in phpBB validation queue).

@canonknipser canonknipser added this to the 1.1.0 milestone Sep 24, 2017

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Sep 26, 2017

Still need an example?

bcurran3 commented Sep 26, 2017

Still need an example?

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Sep 26, 2017

Owner

Don't think so, hope i can offer a fixed version in the next 2 or 3 days and publish the download link here

Owner

canonknipser commented Sep 26, 2017

Don't think so, hope i can offer a fixed version in the next 2 or 3 days and publish the download link here

canonknipser added a commit that referenced this issue Sep 27, 2017

fix Issue #18
Changed behavor of list labńguage construct in php7

canonknipser added a commit that referenced this issue Sep 27, 2017

canonknipser added a commit that referenced this issue Sep 27, 2017

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Sep 27, 2017

Owner

Hopefully I fixed this issue and got rid of "list()" complete ;)
Can you please test the attached version?

  • local unzip
  • acp - manage extensions - disable
  • upload files to /ext/canonknipser/viewexif
  • acp - manage extensions - enable

Works with php 5.6, but actually I don't have a running php 7 test environment
canonknipser_viewexif_1_1_0.zip

Owner

canonknipser commented Sep 27, 2017

Hopefully I fixed this issue and got rid of "list()" complete ;)
Can you please test the attached version?

  • local unzip
  • acp - manage extensions - disable
  • upload files to /ext/canonknipser/viewexif
  • acp - manage extensions - enable

Works with php 5.6, but actually I don't have a running php 7 test environment
canonknipser_viewexif_1_1_0.zip

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Sep 27, 2017

Owner

@bcurran3 : my extension was just rejected by the phpBB validation team because of some minor issues. I just finished a new package with those issues fixed:
canonknipser_viewexif_1_1_1.zip

Owner

canonknipser commented Sep 27, 2017

@bcurran3 : my extension was just rejected by the phpBB validation team because of some minor issues. I just finished a new package with those issues fixed:
canonknipser_viewexif_1_1_1.zip

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Oct 1, 2017

I just downloaded and installed 1.1.1.
Post install, massive errors, went back and disabled and deleted data and errors went away.
I'll watch for errors. I wish I would have noted which threads with pictures had problems. :(
So far seems to be working fine.

bcurran3 commented Oct 1, 2017

I just downloaded and installed 1.1.1.
Post install, massive errors, went back and disabled and deleted data and errors went away.
I'll watch for errors. I wish I would have noted which threads with pictures had problems. :(
So far seems to be working fine.

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Oct 1, 2017

Owner

You are saying "working fine" - so, after you disabled and deleted data you enabled it again?

Owner

canonknipser commented Oct 1, 2017

You are saying "working fine" - so, after you disabled and deleted data you enabled it again?

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Oct 1, 2017

Yepper depper.

Deleting data seems to be a necessity.

I just viewed 10-12 threads with pictures and no problems so far.

bcurran3 commented Oct 1, 2017

Yepper depper.

Deleting data seems to be a necessity.

I just viewed 10-12 threads with pictures and no problems so far.

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Oct 1, 2017

Owner

Sounds good ;)
As a side note (but I know you know): before upgrading a phpBB extension you need to disable a existing version (normally you don't need to "delete data"), upload the new version, enable, finished.

Owner

canonknipser commented Oct 1, 2017

Sounds good ;)
As a side note (but I know you know): before upgrading a phpBB extension you need to disable a existing version (normally you don't need to "delete data"), upload the new version, enable, finished.

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Oct 1, 2017

The method you described was performed.
Disabled.
renamed directory .old
uploaded new files
enabled
fatal errors
disabled
deleted data
enabled
working fine

bcurran3 commented Oct 1, 2017

The method you described was performed.
Disabled.
renamed directory .old
uploaded new files
enabled
fatal errors
disabled
deleted data
enabled
working fine

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Oct 1, 2017

Owner

Oh, I never renamed the old directory during my upgrade tests, just overwritten, maybe that's the cause.
I did upgrade from 1.0.3 to 1.1.0, 1.0.3 to 1.1.1, 1.1.0 to 1.1.1 ...

I'm afraid you did not copy the fatal errors?

Owner

canonknipser commented Oct 1, 2017

Oh, I never renamed the old directory during my upgrade tests, just overwritten, maybe that's the cause.
I did upgrade from 1.0.3 to 1.1.0, 1.0.3 to 1.1.1, 1.1.0 to 1.1.1 ...

I'm afraid you did not copy the fatal errors?

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Oct 1, 2017

No. Sorry, wanted to get it fixed ASAP. Figured if I couldn't fix the problem I'd be reporting it to you right away. If deleting data fixed the problem, error didn't matter (to me).

bcurran3 commented Oct 1, 2017

No. Sorry, wanted to get it fixed ASAP. Figured if I couldn't fix the problem I'd be reporting it to you right away. If deleting data fixed the problem, error didn't matter (to me).

@canonknipser

This comment has been minimized.

Show comment
Hide comment
@canonknipser

canonknipser Oct 7, 2017

Owner

I close this issue because I think it is fixed now with the latest release

Owner

canonknipser commented Oct 7, 2017

I close this issue because I think it is fixed now with the latest release

@bcurran3

This comment has been minimized.

Show comment
Hide comment
@bcurran3

bcurran3 Oct 12, 2017

I have seen no problems, thanks!

bcurran3 commented Oct 12, 2017

I have seen no problems, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment