Remoting project #154

Merged
merged 8 commits into from May 11, 2016

Projects

None yet

3 participants

@aalmiray
Contributor
aalmiray commented May 9, 2016 edited

Pulls in a copy of canoo/open-dolphin @ 9ba5c35


This change is Reviewable

aalmiray added some commits May 9, 2016
@aalmiray aalmiray Update lceinse headers in build files 83f25f6
@aalmiray aalmiray Add remoting projects$ 12d0e4b
@aalmiray aalmiray Remofrmat license headers
2154886
@aalmiray aalmiray added the in progress label May 9, 2016
@aalmiray
Contributor
aalmiray commented May 9, 2016

Note that this PR pulls in Java/Groovy projects only. The JS code must be handled in a separate PR. Waiting for @netopyr to suggest the ideal JS module layout.

aalmiray added some commits May 9, 2016
@aalmiray aalmiray Force JavaFX in classpath
50bf79d
@aalmiray aalmiray Increase test failure logging
3759f30
@aalmiray aalmiray Force initialization of the JavaFX toolkit in tests c2c683a
@hendrikebbers
Member

All JavaFX based tests are failing at travis.

@aalmiray aalmiray Backport canoo/open-dolphin/41
f4bded9
@coveralls

Coverage Status

Coverage increased (+19.9%) to 64.156% when pulling f4bded9 on remoting-project into a88e26a on master.

@hendrikebbers
Member

@aalmiray still working on this one or can I test / review it?

@aalmiray
Contributor
aalmiray commented May 9, 2016

The build is green. You can test it now

@hendrikebbers hendrikebbers added this to the 0.8.5 milestone May 9, 2016
@hendrikebbers
Member

I can build everything but when I start the sample I will get an exception:

Server start: ./gradlew :todo-server-spring:run
Client start: ./gradlew :todo-client:run

Exception in the server when clients starts:

java.lang.ClassNotFoundException: com.canoo.dolphin.internal.EventDispatcher
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.canoo.dolphin.server.context.DolphinContextHandler.handle(DolphinContextHandler.java:102)
at com.canoo.dolphin.server.servlet.DolphinPlatformServlet.doPost(DolphinPlatformServlet.java:39)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:644)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:291)

@aalmiray
Contributor
aalmiray commented May 9, 2016

Can't reproduce on a clean build using both command line and IDE as launchers. Could it be that your environment has out of date artifacts?

@hendrikebbers
Member

I started with ./gradlew clean

@hendrikebbers
Member

All in command line

@hendrikebbers
Member

I think I need some help here. It's not working for me

@hendrikebbers
Member

Updated Gradle but it's still not working:


Gradle 2.13

Build time: 2016-04-25 04:10:10 UTC
Build number: none
Revision: 3b427b1481e46232107303c90be7b05079b05b1c

Groovy: 2.4.4
Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM: 1.8.0_65 (Oracle Corporation 25.65-b01)
OS: Mac OS X 10.11.2 x86_64

@aalmiray aalmiray Switch remoting to OD-RC1 instead of OD-RC3
d8d50b7
@coveralls

Coverage Status

Coverage increased (+20.3%) to 64.511% when pulling d8d50b7 on remoting-project into a88e26a on master.

@hendrikebbers
Member

KumuluzEE example is still not working here but the rest looks good. From my point of view we can merge this. Don't know if you want to change anything.

@aalmiray
Contributor

OK to merge then

@hendrikebbers hendrikebbers merged commit 94960e4 into master May 11, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 64.511%
Details
@hendrikebbers hendrikebbers deleted the remoting-project branch May 11, 2016
@aalmiray aalmiray removed the in progress label May 11, 2016
@hendrikebbers
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment