Error Handling & lifecycle for JavaFX client #255

Merged
merged 7 commits into from Oct 24, 2016

Projects

In Review in Release 0.8.8

4 participants

@hendrikebbers
Member
hendrikebbers commented Aug 30, 2016 edited
  • JavaFX Application lifecycle
  • Error handling
  • ExecutorService provider for JavaFX client

This change is Reviewable

hendrikebbers added some commits Aug 29, 2016
@hendrikebbers hendrikebbers error handling
4e2eed3
@hendrikebbers hendrikebbers Error handling in JavaFX Application
1abca5c
@hendrikebbers hendrikebbers reconnect API
2c83ccb
@hendrikebbers hendrikebbers typo
1553aa6
@hendrikebbers hendrikebbers reconnect button removed
4964e3c
@hendrikebbers hendrikebbers added this to the 0.8.8 milestone Aug 30, 2016
@timo0
Contributor
timo0 commented Sep 15, 2016

Reviewed 4 of 11 files at r1.
Review status: 4 of 11 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


platform-examples/todo-example/todo-client/src/main/java/com/canoo/dolphin/todo/client/ToDoClient.java, line 86 at r1 (raw file):

        ButtonType reconnect = new ButtonType("reconnect");
        //alert.getButtonTypes().addAll(reconnect);

why is this comment out?


platform/dolphin-platform-client/src/main/java/com/canoo/dolphin/client/DolphinRumtimeException.java, line 6 at r1 (raw file):

import org.slf4j.LoggerFactory;

/**

remove this


Comments from Reviewable

@hendrikebbers
Member

Review status: 4 of 11 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


platform-examples/todo-example/todo-client/src/main/java/com/canoo/dolphin/todo/client/ToDoClient.java, line 86 at r1 (raw file):

Previously, timo0 (Timo B) wrote…

why is this comment out?

Reconnect is still not working ;)

platform/dolphin-platform-client/src/main/java/com/canoo/dolphin/client/DolphinRumtimeException.java, line 6 at r1 (raw file):

Previously, timo0 (Timo B) wrote…

remove this

done

Comments from Reviewable

hendrikebbers added some commits Sep 28, 2016
@hendrikebbers hendrikebbers changes based on review
9566c2f
@hendrikebbers hendrikebbers Merge branch 'master' into javafx-error-handling
# Conflicts:
#	platform-examples/todo-example/todo-client/src/main/java/com/canoo/dolphin/todo/client/ToDoClient.java
#	platform/dolphin-platform-client-javafx/src/main/java/com/canoo/dolphin/client/javafx/DolphinPlatformApplication.java
#	platform/dolphin-platform-client/src/main/java/com/canoo/dolphin/client/ClientConfiguration.java
f1b8dcd
@coveralls

Coverage Status

Coverage decreased (-0.8%) to 68.095% when pulling f1b8dcd on javafx-error-handling into c98c8ad on master.

@hendrikebbers hendrikebbers merged commit 2540590 into master Oct 24, 2016

2 of 4 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 68.095%
Details
code-review/reviewable 11 files, 2 discussions left (timo0)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hendrikebbers hendrikebbers deleted the javafx-error-handling branch Oct 24, 2016
@aalmiray aalmiray removed the in progress label Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment