Support for new datatype BigDecimal, BigInteger and UUID #334

Merged
merged 13 commits into from Jan 23, 2017

Projects

None yet

2 participants

@xeonn
Contributor
xeonn commented Jan 20, 2017 edited

Hi,
I have created converter for the above mentioned datatype based on the following issues reported.

#326

Do have a look.

Regards,


This change is Reviewable

hendrikebbers and others added some commits Jan 13, 2017
@hendrikebbers hendrikebbers remove version info for examples
2176304
@hendrikebbers hendrikebbers update version to 0.8.10
6be6402
@hendrikebbers hendrikebbers release update
45109a0
@hendrikebbers hendrikebbers release update
a85381a
@hendrikebbers hendrikebbers release update
349eefe
@xeonn xeonn Ignore .nb-gradle c788ecf
@hendrikebbers @xeonn hendrikebbers documentation 1e33188
@hendrikebbers @xeonn hendrikebbers fix for issue 327 (canoo#327) ed41d0f
@xeonn xeonn Merge branch 'master' into develop 48b448a
@xeonn xeonn Added BigDecimal, BigInteger and UUID converter factory. 7eedb40
@xeonn xeonn Added test unit for BigDecimal, BigInteger and UUID. 08207e2
@xeonn xeonn Register the new datatype. c36d0aa
@hendrikebbers

Awesome work! Thank you :) Can you please change the version number. Once this is done I can merge it.

gradle.properties
@@ -1,5 +1,5 @@
group = com.canoo.dolphin-platform
-version = 0.9.0-SNAPSHOT
+version = 0.8.10
@hendrikebbers
hendrikebbers Jan 20, 2017 Member

please remove this change. The version will be updated when we do a release in a release branch. The master should be always snapshot

@xeonn
xeonn Jan 20, 2017 Contributor

How do I do that? Via new commit? or restructuring the commit?

Sorry, this is my first time creating a pull request in github. Was thinking u are going to cherry-pick the 3 bottom commit.

@hendrikebbers
hendrikebbers Jan 20, 2017 Member

you can simply change it in your branch "xeonn:new-datatype". I think the PR should be updated automatically ;)

@xeonn
xeonn Jan 20, 2017 Contributor

Ok done.

@hendrikebbers hendrikebbers added this to the 0.8.11 milestone Jan 20, 2017
@hendrikebbers hendrikebbers merged commit 0a1ef62 into canoo:master Jan 23, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment