Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactorings of the projector model #900

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@hendrikebbers
Copy link
Contributor

hendrikebbers commented Apr 6, 2018

Some refactorings of the projector model


This change is Reviewable

@clarity-bot

This comment has been minimized.

Copy link

clarity-bot bot commented Apr 6, 2018

I generated a structure-diff below from pulling f0df414 on canoo:projector-model into 5fd5b9c on canoo:master.

Structure Diff

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 6, 2018

Pull Request Test Coverage Report for Build 3100

  • 0 of 41 (0.0%) changed or added relevant lines in 18 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.08%) to 40.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/base/AbstractActionBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/toolbar/ToolbarBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/base/IconBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/table/PropertyColumnBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/base/ViewBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/table/ActionColumnBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/chat/ChatThreadBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/form/AbstractFormFieldBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/form/FormBean.java 0 1 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/notifications/NotificationBean.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
platform-extras/dolphin-platform-projector-server/src/main/java/com/canoo/dp/impl/platform/projector/server/projection/FormFieldBuilder.java 2 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/metadata/concrete/IntegerKeyValueBean.java 2 0.0%
platform-extras/dolphin-platform-projector-common/src/main/java/com/canoo/dp/impl/platform/projector/metadata/concrete/LongKeyValueBean.java 2 0.0%
Totals Coverage Status
Change from base Build 3086: 0.08%
Covered Lines: 4834
Relevant Lines: 11873

💛 - Coveralls

@hendrikebbers hendrikebbers merged commit d399d2a into master Apr 17, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 40.714%
Details
security/snyk No dependency changes
Details

@wafflebot wafflebot bot removed the in progress label Apr 17, 2018

@hendrikebbers hendrikebbers deleted the projector-model branch Apr 17, 2018

@hendrikebbers hendrikebbers added this to the 1.0.0-RC6 milestone Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.