New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript client unable to parse DeletePresentationModelCommand #907

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
3 participants
@manish5196
Contributor

manish5196 commented May 3, 2018

…use javascript client having "DeletePresentationModel" id for DeletePresentationModelCommand

Hi!
Thanks for adding a pull request for Dolphin Platform :)
Please add a short description that explains the changes of your pull request.
We try to review your pull request as fast as possible.


This change is Reviewable

Change DeletePresentationModelCommand to DeletePresentationModel beca…
…use javascript client having "DeletePresentationModel" id for DeletePresentationModelCommand

@wafflebot wafflebot bot added the in progress label May 3, 2018

@manish5196 manish5196 changed the title from Javascript client nable To P to Javascript client unable to parse DeletePresentationModelCommand May 3, 2018

@manish5196 manish5196 requested a review from hendrikebbers May 3, 2018

@manish5196

This comment has been minimized.

Show comment
Hide comment
@manish5196

manish5196 May 3, 2018

Contributor

I did changes for "DeletePresentationModelCommand" to "DeletePresentationModel" in CommandConstant.java because in javascript client in commandConstants.js DELETE_PRESENTATION_MODEL_COMMAND_ID is "DeletePresentationModel"

Contributor

manish5196 commented May 3, 2018

I did changes for "DeletePresentationModelCommand" to "DeletePresentationModel" in CommandConstant.java because in javascript client in commandConstants.js DELETE_PRESENTATION_MODEL_COMMAND_ID is "DeletePresentationModel"

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 3, 2018

Pull Request Test Coverage Report for Build 3123

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 40.189%

Files with Coverage Reduction New Missed Lines %
platform/dolphin-platform-remoting-client/src/main/java/com/canoo/dp/impl/client/legacy/communication/AbstractClientConnector.java 1 90.91%
Totals Coverage Status
Change from base Build 3121: -0.008%
Covered Lines: 4846
Relevant Lines: 12058

💛 - Coveralls

coveralls commented May 3, 2018

Pull Request Test Coverage Report for Build 3123

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 40.189%

Files with Coverage Reduction New Missed Lines %
platform/dolphin-platform-remoting-client/src/main/java/com/canoo/dp/impl/client/legacy/communication/AbstractClientConnector.java 1 90.91%
Totals Coverage Status
Change from base Build 3121: -0.008%
Covered Lines: 4846
Relevant Lines: 12058

💛 - Coveralls

@hendrikebbers hendrikebbers merged commit fb99c1f into master May 3, 2018

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.008%) to 40.189%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details

@wafflebot wafflebot bot removed the in progress label May 3, 2018

@hendrikebbers hendrikebbers deleted the Javascript_Client_Unable_To_Parse_DeletePresentationModelCommand branch May 3, 2018

@hendrikebbers

This comment has been minimized.

Show comment
Hide comment
@hendrikebbers
Contributor

hendrikebbers commented May 3, 2018

@hendrikebbers

This comment has been minimized.

Show comment
Hide comment
@hendrikebbers

hendrikebbers May 4, 2018

Contributor

fix for #906

Contributor

hendrikebbers commented May 4, 2018

fix for #906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment