Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: cantinac/brightcove-wp-plugin
base: f0daa90470
...
head fork: cantinac/brightcove-wp-plugin
compare: 88cb10c610
Checking mergeability… Don't worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 0 commit comments
  • 1 contributor
Showing with 10 additions and 8 deletions.
  1. +6 −5 brightcove.php
  2. +4 −3 dynamic_brightcove.js
View
11 brightcove.php
@@ -242,16 +242,17 @@ function bc_media_upload_form() {
<div id='bc-error' class='hidden error'></div>
</div>
- <div class='media-item no-border player-preview'>
- <table>
+ <div class='media-item no-border player-preview preview-container' style="display: none;">
+ <h3>Video Preview</h3>
+
+ <table>
<tbody>
<tr>
<td>
<div class='alignleft'>
- <h3 id='bc_title'></h3>
+ <h4 id='bc_title'></h4>
<p id='bc_description'></p>
- <p> Video Preview: </p>
- <div id="dynamic-bc-placeholder"> </div>
+ <div id="dynamic-bc-placeholder"></div>
</div>
<div class='alignleft'>
</div>
View
7 dynamic_brightcove.js
@@ -128,7 +128,7 @@ var BCL = {};
BCL.addPlayer = function () {
/*Remove all of the old HTML for the player and the old title and description*/
- $('#dynamic-bc-placeholder').html('');
+ $('#dynamic-bc-placeholder').closest('.preview-container').hide();
$('#bc_title').html('');
$('#bc_description').html('');
@@ -161,7 +161,8 @@ var BCL = {};
});
} else {
- $('#dynamic-bc-placeholder').html(playerHTML);
+ $('#dynamic-bc-placeholder').html(playerHTML).closest('.preview-container').show();
+
}
// instantiate the player
@@ -373,7 +374,7 @@ var BCL = {};
// MAPI: Updates the player preview and the fields below for overriding settings
BCL.setHTML =function (videoId) {
- innerHTML = '<div id="dynamic-bc-placeholder"></div>';
+ var innerHTML = '<div id="dynamic-bc-placeholder"></div>';
innerHTML += '<input class="block" type="text" id="bc-player" placeholder="Player ID" />';
innerHTML += '<input class="block player_data_api" id="bc-width" type="text" placeholder="Width (optional)" />';
innerHTML += '<input class="block player_data_api" type="text" id="bc-height" placeholder="Height (optional)" />';

No commit comments for this range

Something went wrong with that request. Please try again.