This PR, built on @umarsheikh's work in #147, adds the concept of UserCredentials and uses them in the various Twitter Agents.
user credentials can now be shown, and can be removed, still to add t…
Merge branch 'master' into user-credentials
now the adding of the user credential inline is working
why is rails_admin_histories showing here?
model specs and validations
now agents repond to credential method call, and specs
refactor to remove rescue
Merge branch 'user-credentials' of https://github.com/umarsheikh/huginn…
… into umarsheikh-user-credentials
move user credentials to a primary route, update twitter agents and b…
@albertsun, @Alex-Ikanow, @KenYN - I'd love any feedback you have!
Looks good to me, and a much better approach than the hack job I did locally!
Looks good to me.
I think the tap in assignable_types.rb doesn't work with the new Twitter credentials. Since the code in the tap block happens after the Agent is initialized, we call configure_twitter in the TwitterConcern, which tries to access user, after the object initialization but before we assign the user in the tap in build_for_type().
Good catch. I think the after_initialize :configure_twitter in TwitterConcern should really be a callback that runs before the agent does check or receive.
Also, it doesn't look thread safe at all.
Hey @qedi-r, see if this fixes it for you: #168