Skip to content

Omit the protocol from url base of asset. #30

wants to merge 1 commit into from

2 participants

ka2n commented Aug 7, 2012

Make files to available over SSL and non-SSL environment.
Force replace http:// and https:// with //.


Why not get rid of the brackets in the search regex?


Also, I'd prefer to do the replace on \Config::get('base_url') only. Overriding the config key casset.url seems a bit presumptuous.

In addition, now would probably be a good time to use something like URL::base() instead of fetching this config key directly (I don't recall this function existing when that line was written).

canton7 commented Aug 8, 2012

Definitely needs doing, thanks! I've raised a couple of concerns in the commit comments -- what do you think?

@canton7 canton7 closed this in d12af89 Aug 19, 2012
canton7 commented Aug 19, 2012

Finished it up my way and closed it due to lack of feedback

@canton7 canton7 added a commit that referenced this pull request Aug 21, 2012
@canton7 Merge branch 'feature/scheme-relative' into develop
* feature/scheme-relative:
  Add Katsuma Ito to contributers
  Make asset urls scheme-relative, to avoid http/https issues.

Closes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.