Waterfall without nextTick() #152

Closed
manuelcabral opened this Issue Jul 26, 2012 · 3 comments

Comments

Projects
None yet
4 participants

One of reasons I use async.js is to avoid long nesting of function calls.

Recently, I had the need to remove the nextTick() call from waterfall. The reason for this was that one function was getting some input from the user which required clicking a "Submit" button , and the next one was attempting to login on Facebook. The Facebook login pop-up was getting blocked by Safari, since nextTick() make the blocker consider that the pop-up was not appearing in response to a user action (the click on the Submit button).

I've fixed the problem by simply removing the nextTick call, but if more people are interested, I can implement a more elegant solution. What would be the best way to do this? A new syncWaterfall() function? A third parameter being passed to waterfall() and series()?

@ghost

ghost commented Sep 16, 2012

+1. syncWaterfall

mlogan commented Dec 20, 2012

I got bitten by this, and would be interested in a fix. There's no reason to defer any processing in waterfall to a subsequent tick, and its quite confusing given that async.series doesn't use nextTick.

statico commented Dec 20, 2012

+1

caolan closed this Mar 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment