Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

What is line 121 (in async.js) doing? #19

Closed
ghost opened this Issue Apr 1, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Apr 1, 2011

Hi caolan,

Just curious: What is line 121 doing? It seems redundant:
https://github.com/caolan/async/blob/master/lib/async.js#L121

Owner

caolan commented Apr 2, 2011

I think you might be right ;) ...it makes sense in the parallel forEach because we only want to return the first error (and not call the callback multiple times), but for the series version the callback should only be called once anyway.

Contributor

brianmaissy commented Feb 20, 2013

I assume this has since been fixed? If not, what is the current number of the line this is referring to?

Owner

caolan commented Mar 2, 2013

closing for now, please create another issue or reopen if you find this problem again.

@caolan caolan closed this Mar 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment