"completed" counter issue with async.forEach #121

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@dkastner

An issue appears in Chrome (but not node) where the completed counter goes above the array length on a forEach. Somehow the === comparison between completed and arr.length is failing.

Not sure the exact cause and I had trouble coming up with a test to reproduce, but thought I'd throw it out there for your consideration.

@dkastner dkastner Use a more "liberal" loop counter
An issue appears in Chrome (but not node)
where the completed counter goes above the
array length on a forEach. Somehow the ===
comparison between completed and arr.length
is failing.
7d6f5c9
@caolan caolan closed this in f839572 Jan 31, 2013
@caolan
Owner
caolan commented Jan 31, 2013

That sounds very odd, but the fix seems equally correct as a strict equals check, so happy to accept it instead of wondering why the rest of the world, and Chrome in particular, is not behaving as it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment