`waterfall` now passes all arguments to callback even if there was an error. #141

merged 1 commit into from Jan 31, 2013


None yet

4 participants


The fact that waterfall doesn't pass all arguments in case of an error is bad because one could be triggering errors on purpose while still wanting to maintain certain flow of data.




@caolan Can I get your thoughts on this PR? Was it intentional to not pass all arguments to the completed callback?


@caolan Thoughts on pushing this small fix through?


Please, this fix is very important.

@caolan caolan merged commit 6462a5a into caolan:master Jan 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment