Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Makefile to include source map in build dir [fixes #1452] #1453

Merged
merged 1 commit into from Jul 24, 2017

Conversation

hargasinski
Copy link
Collaborator

@hargasinski hargasinski commented Jul 21, 2017

I haven't worked with make files too much, so I just wanted a second set of eyes before merging. Thanks!

@hargasinski hargasinski self-assigned this Jul 21, 2017
@hargasinski
Copy link
Collaborator Author

@hargasinski hargasinski commented Jul 21, 2017

This build and master are failing due to ansi-styles@2.2.0, as it is included in the package-lock.json, but the actual module has been unpublished (see: chalk/ansi-styles#15, npm/npm#17723). I'll look more into it tomorrow.

aearly
aearly approved these changes Jul 23, 2017
@aearly
Copy link
Collaborator

@aearly aearly commented Jul 23, 2017

This looks good, thanks! We'll fix CI in another PR.

@hargasinski hargasinski merged commit 4aae892 into master Jul 24, 2017
1 of 3 checks passed
@aearly aearly deleted the include-source-map-in-build branch May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants