Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicit filepath #1769

Merged
merged 1 commit into from Nov 16, 2021
Merged

fix: Explicit filepath #1769

merged 1 commit into from Nov 16, 2021

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Nov 10, 2021

You are not truly using ESM unless you are not specifying the extension.
you are compiling to commonjs after all...

remote http path resolver (like http-import) don't have access to the filesystem and can't resolve ./foo to ./foo.js or ./foo/index.js it's unable to guess what you meant

https://nodejs.org/docs/latest-v17.x/api/esm.html#mandatory-file-extensions

the only thing i think you have left to do is adding "type": "module" in package.json and stop generating cjs/umd and just output esm, but this is up to you - at least now this is more cdn friendly

@jimmywarting jimmywarting changed the title be explicit fix: explicit filepath Nov 10, 2021
@jimmywarting jimmywarting changed the title fix: explicit filepath fix: Explicit filepath Nov 10, 2021
@aearly aearly merged commit bb41f2a into caolan:master Nov 16, 2021
5 checks passed
@aearly
Copy link
Collaborator

@aearly aearly commented Nov 16, 2021

Thanks. ESM support has changed out from underneath us since we did the initial switch to ESM.

@jimmywarting jimmywarting deleted the extension branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants