Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #1772

Merged
merged 9 commits into from Dec 2, 2021
Merged

Housekeeping #1772

merged 9 commits into from Dec 2, 2021

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Nov 16, 2021

When installing all dependencies then it yields some deprecation warnings. some packages wasn't even being used.
Where going to fix some of it but ended up doing something else instead.


Where thinking of removing fs-extra also but though if i should ask first...
it seems to only be used in development to fix some docs and reading some files
i where thinking that it wouldn't be so bad if it used nodes native fs after all
And b/c it's dev only and mostly one time thing. i think it wouldn't be nice to use the sync api instead to remove some "callback-hell" stuff and avoid the need of async and or promises.
the sync methods are faster after all but they are blocking...

aearly
aearly approved these changes Nov 17, 2021
Copy link
Collaborator

@aearly aearly left a comment

Thanks for this! The docs generation scripts could use a bit of love as well. They were written when async / await support wasn't that great in Node.

@jimmywarting
Copy link
Contributor Author

@jimmywarting jimmywarting commented Nov 17, 2021

would it be alright to use sync version instead?

@aearly aearly merged commit 2ee673f into caolan:master Dec 2, 2021
5 checks passed
@jimmywarting jimmywarting deleted the update-devDep branch Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants