Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup GitHub Actions #1782

Merged
merged 1 commit into from Jan 10, 2022
Merged

ci: setup GitHub Actions #1782

merged 1 commit into from Jan 10, 2022

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jan 7, 2022

Was hitting some macOS issues that I thought might be coming from here, so i thought it might be good to add back a full test matrix.
I left in the Azure DevOps CI, but only added in 12+ node versions since Node 10 is EOL

- name: Run browser tests
run: npm run mocha-browser-test -- --browsers ${{ matrix.browser }} --timeout 10000
env:
DISPLAY: :99.0
Copy link
Contributor Author

@nschonni nschonni Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be needed anymore since switching to FirefoxHeadless

Copy link
Contributor Author

@nschonni nschonni left a comment

- 17
os: [ubuntu-latest, macos-latest, windows-latest]
browser:
- FirefoxHeadless
Copy link
Contributor Author

@nschonni nschonni Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge and Safari runners seems to be abandoned and a little flaky, so didn't add them in, but can be added on platform specific includes:

@aearly
Copy link
Collaborator

@aearly aearly commented Jan 10, 2022

Thanks for doing this, I didn't realize Travis has basically shut down.

@aearly aearly merged commit a038c8f into caolan:master Jan 10, 2022
5 checks passed
@nschonni nschonni deleted the github-actions branch Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants