Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement doWhilst via whilst #823

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jul 1, 2015

No description provided.

@megawac megawac changed the title Implement whilst via doWhilst Implement doWhilst via whilst Jul 1, 2015
@aearly
Copy link
Collaborator

aearly commented Jul 1, 2015

Hmnn, this means that the second and later invocations of the test in whilst will be called with the callback arguments -- might lead to subtle breaking changes. I'm sure most people are passing a function expression with no parameters, but some people might be passing a variadic method somehow.

@megawac
Copy link
Collaborator Author

megawac commented Jul 2, 2015

I mean, if people don't expect parameters they won't be handling them. I would be extremely surprised if this broke anyones code (plus its a nice little enhancement to whilst (same goes for during in the other pr)

aearly added a commit that referenced this pull request Jul 2, 2015
Implement doWhilst via whilst
@aearly aearly merged commit 9bdbb64 into caolan:master Jul 2, 2015
@aearly
Copy link
Collaborator

aearly commented Jul 2, 2015

Okay, I guess we'll try it and see...

@megawac megawac mentioned this pull request Jul 10, 2015
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants