Changes to caolan/forms #14

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@vkareh

vkareh commented Dec 8, 2011

Hello caolan

Thanks for your forms node module! I really like the shorthand way for creating forms quickly. I made a few changes to it that I hope you'll like:

  • Added optional handlers for submit buttons and form method.
  • Changed a string.replace() to a regex (for element id) so that it replaces more than just the first underscore when creating the label.
  • Added documentation for the submit button.

Cheers!
vkareh

@ljharb

This comment has been minimized.

Show comment Hide comment
@ljharb

ljharb May 22, 2012

Collaborator

I've commented about the button widget - but in addition, the only valid form methods allowed should be /^(get|post)$/i, and you're not escaping double quotes in the form action, nor checking for URL validity (altho checking validity might be a bit much).

Collaborator

ljharb commented May 22, 2012

I've commented about the button widget - but in addition, the only valid form methods allowed should be /^(get|post)$/i, and you're not escaping double quotes in the form action, nor checking for URL validity (altho checking validity might be a bit much).

@ljharb

This comment has been minimized.

Show comment Hide comment
@ljharb

ljharb May 9, 2013

Collaborator

Closing since there's been a year with no response.

Collaborator

ljharb commented May 9, 2013

Closing since there's been a year with no response.

@ljharb ljharb closed this May 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment