Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix a bug which cause scripts on command line run out of order #171

Open
wants to merge 1 commit into from

3 participants

@alexzhuustc

There is a code processes path in parallel mode which MAY cause run scripts out of order.

e.g.
nodeunit a.js b.js c.js d.js
the execute order may looks like
-> b.js
-> c.js
-> a.js
-> d.js

I believe it's not an intended design, as all other codes are carefully handle path in series mode.

@alexzhuustc alexzhuustc There is a code processes path in parallel mode which MAY cause run s…
…cripts out of order.

e.g.
  nodeunit a.js b.js c.js d.js
  the output may looks like
    -> b.js
    -> c.js
    -> a.js
    -> d.js

I believe it's not an intended design. Because all other codes are carefully handle path in series mode.
029b847
@Sannis

+1 on this.

@KishCom

Are there plans to integrate this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 1, 2012
  1. @alexzhuustc

    There is a code processes path in parallel mode which MAY cause run s…

    alexzhuustc authored
    …cripts out of order.
    
    e.g.
      nodeunit a.js b.js c.js d.js
      the output may looks like
        -> b.js
        -> c.js
        -> a.js
        -> d.js
    
    I believe it's not an intended design. Because all other codes are carefully handle path in series mode.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/utils.js
View
2  lib/utils.js
@@ -44,7 +44,7 @@ catch (e) {
*/
exports.modulePaths = function (paths, callback) {
- async.concat(paths, function (p, cb) {
+ async.concatSeries(paths, function (p, cb) {
fs.stat(p, function (err, stats) {
if (err) {
return cb(err);
Something went wrong with that request. Please try again.