Update Package.json #336

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@bbhagwandeen

As a part of an open source development course I am taking, using Package.json validator revealed some recommendations to this package.json file. As such, I have attempted to add some keywords.

Update Package.json
As a part of an open source development course I am taking, using Package.json validator revealed some recommendations to this package.json file. As such, I have attempted to add some keywords.
@mreinstein

This comment has been minimized.

Show comment
Hide comment
@mreinstein

mreinstein Jan 31, 2017

Collaborator

I appreciate the effort! There are 2 issues with this pull request:

1 - it breaks the package.json this file must be valid JSON. Your changes make this invalid

2 - the particular keywords chosen are not super relevant. For example, "html" is included, and nodeunit has practically nothing to do with html

Thank you for taking the time to submit though! Keep practicing!

Collaborator

mreinstein commented Jan 31, 2017

I appreciate the effort! There are 2 issues with this pull request:

1 - it breaks the package.json this file must be valid JSON. Your changes make this invalid

2 - the particular keywords chosen are not super relevant. For example, "html" is included, and nodeunit has practically nothing to do with html

Thank you for taking the time to submit though! Keep practicing!

@mreinstein mreinstein closed this Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment