From 64eaf92645e609b8ddce71f317bcc8121f48d74f Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Tue, 6 Aug 2024 16:15:17 +0530 Subject: [PATCH 01/18] Sonar Workflow --- .github/workflows/sonarqube.yml | 57 ++++++++++++++++++++++++++++++++ .github/workflows/unit.tests.yml | 2 +- 2 files changed, 58 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/sonarqube.yml diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml new file mode 100644 index 00000000..a36e336a --- /dev/null +++ b/.github/workflows/sonarqube.yml @@ -0,0 +1,57 @@ +name: SonarQube analysis + +on: + push: + branches: + - develop + pull_request: + branches: + - develop + types: [opened, synchronize, reopened] + workflow_dispatch: + +permissions: + pull-requests: read # allows SonarQube to decorate PRs with analysis results + +jobs: + build: + runs-on: cap-java + steps: + - name: Checkout code + uses: actions/checkout@v4 + with: + fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis + + - name: Set up JDK 17 + uses: actions/setup-java@v4 + with: + java-version: '17' + distribution: 'temurin' + cache: maven + + - name: Install dependencies and run tests + run: | + mvn clean install + + - name: Analyze with SonarQube + uses: sonarsource/sonarqube-scan-action@master + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} + with: + # Additional arguments for the sonarcloud scanner + args: | + -Dsonar.projectKey=cap-java-sdm + -Dsonar.sources=sdm/src/main/java + -Dsonar.java.binaries=target/classes + -Dsonar.junit.reportPaths=target/surefire-reports + -Dsonar.jacoco.reportPaths=target/jacoco.exec + -Dsonar.inclusions=**/*.java + -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb + -Dsonar.java.file.suffixes=.java + + - name: Quality Gate Check + uses: sonarsource/sonarqube-quality-gate-action@master + timeout-minutes: 5 + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} \ No newline at end of file diff --git a/.github/workflows/unit.tests.yml b/.github/workflows/unit.tests.yml index 7e1f9335..c8fcde39 100644 --- a/.github/workflows/unit.tests.yml +++ b/.github/workflows/unit.tests.yml @@ -21,7 +21,7 @@ jobs: uses: actions/checkout@v4 - name: Set up JDK ${{ matrix.java-version }} - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: 'temurin' java-version: ${{ matrix.java-version }} From 774d80bd6c8fa9c74833133b7b167165dc4e7d6a Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 10:27:41 +0530 Subject: [PATCH 02/18] Update runner to github-hosted runner --- .github/workflows/sonarqube.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index a36e336a..ae519786 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -15,7 +15,7 @@ permissions: jobs: build: - runs-on: cap-java + runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v4 @@ -29,9 +29,9 @@ jobs: distribution: 'temurin' cache: maven - - name: Install dependencies and run tests - run: | - mvn clean install + # - name: Install dependencies and run tests + # run: | + # mvn clean install - name: Analyze with SonarQube uses: sonarsource/sonarqube-scan-action@master From cc896cd8cac6f7f831f28d8aed4408ff8e22f9e0 Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 10:57:17 +0530 Subject: [PATCH 03/18] Switch to SonarQube Scanner CLI to avoid Docker CLI --- .github/workflows/sonarqube.yml | 55 +++++++++++++++++++-------------- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index ae519786..87c99ea8 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -11,16 +11,17 @@ on: workflow_dispatch: permissions: - pull-requests: read # allows SonarQube to decorate PRs with analysis results + pull-requests: read # allows SonarQube to decorate PRs with analysis results jobs: build: - runs-on: ubuntu-latest + runs-on: cap-java + steps: - name: Checkout code uses: actions/checkout@v4 with: - fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis + fetch-depth: 0 # Ensure shallow clones are disabled for better analysis relevancy - name: Set up JDK 17 uses: actions/setup-java@v4 @@ -28,30 +29,36 @@ jobs: java-version: '17' distribution: 'temurin' cache: maven - - # - name: Install dependencies and run tests - # run: | - # mvn clean install - - name: Analyze with SonarQube - uses: sonarsource/sonarqube-scan-action@master - env: - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} - with: - # Additional arguments for the sonarcloud scanner - args: | - -Dsonar.projectKey=cap-java-sdm - -Dsonar.sources=sdm/src/main/java - -Dsonar.java.binaries=target/classes - -Dsonar.junit.reportPaths=target/surefire-reports - -Dsonar.jacoco.reportPaths=target/jacoco.exec - -Dsonar.inclusions=**/*.java - -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb - -Dsonar.java.file.suffixes=.java + - name: Install dependencies and run tests + run: | + mvn clean install + + - name: Install SonarQube Scanner + run: | + curl -sSLo sonar-scanner-cli.zip https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-4.7.0.2747-linux.zip + unzip sonar-scanner-cli.zip + sudo mv sonar-scanner-4.7.0.2747-linux /opt/sonar-scanner + sudo ln -s /opt/sonar-scanner/bin/sonar-scanner /usr/local/bin/sonar-scanner + + - name: Run SonarQube analysis + run: | + sonar-scanner \ + -Dsonar.projectKey=cap-java-sdm \ + -Dsonar.sources=sdm/src/main/java \ + -Dsonar.java.binaries=target/classes \ + -Dsonar.junit.reportPaths=target/surefire-reports \ + -Dsonar.jacoco.reportPaths=target/jacoco.exec \ + -Dsonar.inclusions=**/*.java \ + -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ + -Dsonar.java.file.suffixes=.java \ + -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ + -Dsonar.login=${{ secrets.SONAR_TOKEN }} - name: Quality Gate Check + id: sonarqube-quality-gate uses: sonarsource/sonarqube-quality-gate-action@master - timeout-minutes: 5 + with: + sonar_host_url: ${{ secrets.SONAR_HOST_URL }} env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} \ No newline at end of file From a3cdc18de85fde372aee7ef38da751ba806924a8 Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 11:03:52 +0530 Subject: [PATCH 04/18] skip UTs --- .github/workflows/sonarqube.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 87c99ea8..9c78e827 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -32,7 +32,7 @@ jobs: - name: Install dependencies and run tests run: | - mvn clean install + mvn install -DskipTests - name: Install SonarQube Scanner run: | From d4566dc90edb5cdb60d2c5c551a0ed75695ac61c Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 11:07:56 +0530 Subject: [PATCH 05/18] path correction --- .github/workflows/sonarqube.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 9c78e827..b7464118 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -46,9 +46,9 @@ jobs: sonar-scanner \ -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ - -Dsonar.java.binaries=target/classes \ - -Dsonar.junit.reportPaths=target/surefire-reports \ - -Dsonar.jacoco.reportPaths=target/jacoco.exec \ + -Dsonar.java.binaries=sdm/target/classes \ + -Dsonar.junit.reportPaths=sdm/target/surefire-reports \ + -Dsonar.jacoco.reportPaths=sdm/target/jacoco.exec \ -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ From 5f83aa06aaa031c624f66066fc0b5bebb369bb53 Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 11:14:20 +0530 Subject: [PATCH 06/18] Add conditional symlink creation --- .github/workflows/sonarqube.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index b7464118..27b4dc4c 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -36,10 +36,12 @@ jobs: - name: Install SonarQube Scanner run: | - curl -sSLo sonar-scanner-cli.zip https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-4.7.0.2747-linux.zip - unzip sonar-scanner-cli.zip - sudo mv sonar-scanner-4.7.0.2747-linux /opt/sonar-scanner - sudo ln -s /opt/sonar-scanner/bin/sonar-scanner /usr/local/bin/sonar-scanner + if [ ! -L /usr/local/bin/sonar-scanner ]; then + curl -sSLo sonar-scanner-cli.zip https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-4.7.0.2747-linux.zip + unzip sonar-scanner-cli.zip + sudo mv sonar-scanner-4.7.0.2747-linux /opt/sonar-scanner + sudo ln -s /opt/sonar-scanner/bin/sonar-scanner /usr/local/bin/sonar-scanner + fi - name: Run SonarQube analysis run: | From 1764c2592a74598e4f5cce224719ffa5c76aa6d4 Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 14:30:58 +0530 Subject: [PATCH 07/18] remove unit-tests related configurations from sonar --- .github/workflows/sonarqube.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 27b4dc4c..9c8cc110 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -32,7 +32,7 @@ jobs: - name: Install dependencies and run tests run: | - mvn install -DskipTests + mvn clean install -DskipTests - name: Install SonarQube Scanner run: | @@ -49,8 +49,6 @@ jobs: -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ -Dsonar.java.binaries=sdm/target/classes \ - -Dsonar.junit.reportPaths=sdm/target/surefire-reports \ - -Dsonar.jacoco.reportPaths=sdm/target/jacoco.exec \ -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ From d3697c35144c8bbb66b4a6b2cb461fac4424f92e Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 14:50:28 +0530 Subject: [PATCH 08/18] add java.libraries parameter in sonar config --- .github/workflows/sonarqube.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 9c8cc110..8456653e 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -49,6 +49,7 @@ jobs: -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ -Dsonar.java.binaries=sdm/target/classes \ + -Dsonar.java.libraries=sdm/target/*.jar \ -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ From bc4980db7c063686f195e7509ed9ab1f5321f021 Mon Sep 17 00:00:00 2001 From: "Yashmeet ." Date: Wed, 7 Aug 2024 16:50:03 +0530 Subject: [PATCH 09/18] Test sonar with reduced codeCoverage --- .github/workflows/sonarqube.yml | 9 ++++++--- sdm/pom.xml | 8 ++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 8456653e..7d3ae848 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -30,9 +30,9 @@ jobs: distribution: 'temurin' cache: maven - - name: Install dependencies and run tests + - name: Install dependencies run: | - mvn clean install -DskipTests + mvn clean install - name: Install SonarQube Scanner run: | @@ -49,12 +49,15 @@ jobs: -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ -Dsonar.java.binaries=sdm/target/classes \ - -Dsonar.java.libraries=sdm/target/*.jar \ + -Dsonar.java.libraries=sdm/target/sdm.jar \ + -Dsonar.junit.reportPaths=sdm/target/surefire-reports \ + -Dsonar.coverage.jacoco.xmlReportPaths=sdm/target/site/jacoco/jacoco.xml \ -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} + -Dsonar.verbose=true # Increase verbosity for debugging - name: Quality Gate Check id: sonarqube-quality-gate diff --git a/sdm/pom.xml b/sdm/pom.xml index 58353ffa..047f2326 100644 --- a/sdm/pom.xml +++ b/sdm/pom.xml @@ -222,22 +222,22 @@ INSTRUCTION COVEREDRATIO - 0.90 + 0.00 BRANCH COVEREDRATIO - 0.90 + 0.00 COMPLEXITY COVEREDRATIO - 0.90 + 0.00 CLASS MISSEDCOUNT - 0 + 5 From 12c2ca21c50712683dd3db2f4b746cc46bc0398c Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:13:25 +0530 Subject: [PATCH 10/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 7d3ae848..0cbc13f4 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -58,6 +58,9 @@ jobs: -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} -Dsonar.verbose=true # Increase verbosity for debugging + -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} + -Dsonar.pullrequest.branch=${{ github.head_ref }} + -Dsonar.pullrequest.base=${{ github.base_ref }} - name: Quality Gate Check id: sonarqube-quality-gate @@ -65,4 +68,4 @@ jobs: with: sonar_host_url: ${{ secrets.SONAR_HOST_URL }} env: - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} \ No newline at end of file + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} From a78acf20af739b704d60cd2bc8e69d1e1188b60e Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:15:16 +0530 Subject: [PATCH 11/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 0cbc13f4..87cbacce 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -57,7 +57,7 @@ jobs: -Dsonar.java.file.suffixes=.java \ -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} - -Dsonar.verbose=true # Increase verbosity for debugging + -Dsonar.verbose=false # Increase verbosity for debugging -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} -Dsonar.pullrequest.branch=${{ github.head_ref }} -Dsonar.pullrequest.base=${{ github.base_ref }} From 350c6ace93e9adefe7b5425cbd1f7c542034e7c4 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:21:07 +0530 Subject: [PATCH 12/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 87cbacce..867a7ca4 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -57,7 +57,6 @@ jobs: -Dsonar.java.file.suffixes=.java \ -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} - -Dsonar.verbose=false # Increase verbosity for debugging -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} -Dsonar.pullrequest.branch=${{ github.head_ref }} -Dsonar.pullrequest.base=${{ github.base_ref }} From b7bb70aec22198968ef1ead044bc50b2d7876ec6 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:28:20 +0530 Subject: [PATCH 13/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 867a7ca4..79281789 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -42,10 +42,14 @@ jobs: sudo mv sonar-scanner-4.7.0.2747-linux /opt/sonar-scanner sudo ln -s /opt/sonar-scanner/bin/sonar-scanner /usr/local/bin/sonar-scanner fi - - - name: Run SonarQube analysis - run: | - sonar-scanner \ + - name: Analyze with SonarQube + uses: sonarsource/sonarqube-scan-action@master + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} + with: + # Additional arguments for the sonarcloud scanner + args: -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ -Dsonar.java.binaries=sdm/target/classes \ @@ -55,11 +59,7 @@ jobs: -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ - -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ - -Dsonar.login=${{ secrets.SONAR_TOKEN }} - -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} - -Dsonar.pullrequest.branch=${{ github.head_ref }} - -Dsonar.pullrequest.base=${{ github.base_ref }} + -Dsonar.verbose=false - name: Quality Gate Check id: sonarqube-quality-gate From 6336bdb12e95207b6e5c7029910ae5c47ca4d7e9 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:35:01 +0530 Subject: [PATCH 14/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 79281789..8e3c5fcc 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -42,14 +42,10 @@ jobs: sudo mv sonar-scanner-4.7.0.2747-linux /opt/sonar-scanner sudo ln -s /opt/sonar-scanner/bin/sonar-scanner /usr/local/bin/sonar-scanner fi - - name: Analyze with SonarQube - uses: sonarsource/sonarqube-scan-action@master - env: - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }} - with: - # Additional arguments for the sonarcloud scanner - args: + + - name: Run SonarQube analysis + run: | + sonar-scanner \ -Dsonar.projectKey=cap-java-sdm \ -Dsonar.sources=sdm/src/main/java \ -Dsonar.java.binaries=sdm/target/classes \ @@ -59,7 +55,9 @@ jobs: -Dsonar.inclusions=**/*.java \ -Dsonar.exclusions=**/target/**,**/node_modules/**,sdm/src/main/test/**,cap-notebook/*.capnb \ -Dsonar.java.file.suffixes=.java \ - -Dsonar.verbose=false + -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ + -Dsonar.login=${{ secrets.SONAR_TOKEN }} + -Dsonar.verbose=false # Increase verbosity for debugging - name: Quality Gate Check id: sonarqube-quality-gate From 519bfe4a274efb2dd4a4ad3162762cf2c6699a8b Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:38:27 +0530 Subject: [PATCH 15/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 8e3c5fcc..6f18fe1b 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -57,7 +57,7 @@ jobs: -Dsonar.java.file.suffixes=.java \ -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} - -Dsonar.verbose=false # Increase verbosity for debugging + -Dsonar.verbose=true # Increase verbosity for debugging - name: Quality Gate Check id: sonarqube-quality-gate From 570736ea6dd7b197902db04e0aeba94deb54bb76 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:42:16 +0530 Subject: [PATCH 16/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 6f18fe1b..51f49cf7 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -57,7 +57,7 @@ jobs: -Dsonar.java.file.suffixes=.java \ -Dsonar.host.url=${{ secrets.SONAR_HOST_URL }} \ -Dsonar.login=${{ secrets.SONAR_TOKEN }} - -Dsonar.verbose=true # Increase verbosity for debugging + - name: Quality Gate Check id: sonarqube-quality-gate From 807edda1588c74bbd361367dd0a16bd0da491c16 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:47:58 +0530 Subject: [PATCH 17/18] Update sonarqube.yml --- .github/workflows/sonarqube.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml index 51f49cf7..4d385839 100644 --- a/.github/workflows/sonarqube.yml +++ b/.github/workflows/sonarqube.yml @@ -32,7 +32,7 @@ jobs: - name: Install dependencies run: | - mvn clean install + mvn clean install -DskipTests - name: Install SonarQube Scanner run: | From 3f3a13653ea0da8d784636ce82b46bbfcf19da77 Mon Sep 17 00:00:00 2001 From: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com> Date: Wed, 7 Aug 2024 18:49:40 +0530 Subject: [PATCH 18/18] Update pom.xml --- sdm/pom.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdm/pom.xml b/sdm/pom.xml index 047f2326..58353ffa 100644 --- a/sdm/pom.xml +++ b/sdm/pom.xml @@ -222,22 +222,22 @@ INSTRUCTION COVEREDRATIO - 0.00 + 0.90 BRANCH COVEREDRATIO - 0.00 + 0.90 COMPLEXITY COVEREDRATIO - 0.00 + 0.90 CLASS MISSEDCOUNT - 5 + 0