Skip to content

Conversation

@rishikunnath2747
Copy link
Collaborator

Describe your changes

Modifying CDS file to add name annotations for new method of defining secondary properties

Any documentation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

@vibhutikumar07 vibhutikumar07 merged commit bf00552 into develop_deploy May 22, 2025
1 check passed
@vibhutikumar07 vibhutikumar07 deleted the develop_annotations branch May 22, 2025 09:14
vibhutikumar07 added a commit that referenced this pull request Jun 12, 2025
* Delete cap-notebook/demoapp/app/package-lock.json

* Update package.json

* Update fiori-service.cds

Multiple attachments

* Update attachment-extension.cds

Multiple attachments

* Update attachment-extension.cds

* Revert "Update fiori-service.cds" (#184)

* Revert "Update attachment-extension.cds" (#185)

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>

* added extended fields (#187)

* Added References ,Footnotes annotation (#186)

* Added Reference,footnotes annotation

* Fixed formatting

---------

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>

* Update attachment-extension.cds

* Update attachment-extension.cds

* Update pom.xml

* Update pom.xml

* update cds file (#201)

* New UserService Init

* Update admin-service.cds

Adding system-user for technical user changes.

* Update pom.xml

* Update pom.xml

* Update attachment-extension.cds

Changes for drop down

* Add files via upload

Files for dropdown

* Update attachment-extension.cds

Importing codelist

* fix for dropwdown

* changes

* update cds file

* [CHANGED]: Attachment Extension

* Update attachment-extension.cds

Changes required to add drop down input field.

* Update fiori-service.cds

Updating fiori-services.cds file to encorporate drop down input type.

* remove annotation

---------

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>
Co-authored-by: Akshat Jain <72684535+akshatjain-official@users.noreply.github.com>
Co-authored-by: yashmeet29 <160218676+yashmeet29@users.noreply.github.com>
Co-authored-by: Akshat Jain <akshat.jain02@sap.com>
Co-authored-by: PujaDeshmukh17 <126158971+PujaDeshmukh17@users.noreply.github.com>
vibhutikumar07 added a commit that referenced this pull request Jun 16, 2025
* Delete cap-notebook/demoapp/app/package-lock.json

* Update package.json

* Update fiori-service.cds

Multiple attachments

* Update attachment-extension.cds

Multiple attachments

* Update attachment-extension.cds

* Revert "Update fiori-service.cds" (#184)

* Revert "Update attachment-extension.cds" (#185)

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>

* added extended fields (#187)

* Added References ,Footnotes annotation (#186)

* Added Reference,footnotes annotation

* Fixed formatting

---------

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>

* Update attachment-extension.cds

* Update attachment-extension.cds

* Update pom.xml

* Update pom.xml

* update cds file (#201)

* New UserService Init

* Update admin-service.cds

Adding system-user for technical user changes.

* Update pom.xml

* Update pom.xml

* Update attachment-extension.cds

Changes for drop down

* Add files via upload

Files for dropdown

* Update attachment-extension.cds

Importing codelist

* fix for dropwdown

* changes

* update cds file

* [CHANGED]: Attachment Extension

* Update attachment-extension.cds

Changes required to add drop down input field.

* Update fiori-service.cds

Updating fiori-services.cds file to encorporate drop down input type.

---------

Co-authored-by: vibhutikumar <160819926+vibhutikumar07@users.noreply.github.com>
Co-authored-by: Akshat Jain <72684535+akshatjain-official@users.noreply.github.com>
Co-authored-by: yashmeet29 <160218676+yashmeet29@users.noreply.github.com>
Co-authored-by: Akshat Jain <akshat.jain02@sap.com>
Co-authored-by: PujaDeshmukh17 <126158971+PujaDeshmukh17@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants