fix: GraphiQL Explorer Plugin CDN URL #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-vogel
approved these changes
Jul 5, 2023
johannes-vogel
added a commit
that referenced
this pull request
Jul 5, 2023
* refactor: move graphiql GET route registration into `graphiql.js` (#98) * Move graphiql GET route registration into graphiql.js * Remove underscore prefix since function isn't private * chore: prepare next release (#99) * adapt urls and references to repo name (#100) * feat: improved query logging (#85) * Don't log 'GET undefined' when missing query * WIP improved request logger * Add operationName and variables to object * Extract request logger to own module * Add changelog entry * Reformat changelog entry * Remove outdated changelog entry * Remove padding after query * Prettier format * Log `operationName` and `variables` from URL query parameter * Parse variables JSON string if taken from `req.query` * Add typeof object short-circuiting before Object.keys * Sanitize arguments and their values in production * Reorder changelog entries * Rename requestLogger to queryLogger * Add query logging tests * Rename `logger.test.js` to `logger-dev.test.js` * Add test for log sanetization in production * Prettier format * Fix logger module path * Fix truncation of nested variables * Fix typo * Move object formatting to only affect query info object * Add and improve comments * Log variables object as '***' in production * Fix typo * Use mocked instead of dummy auth * Add dev logging tests to prod to ensure no unwanted values are sanitized * Add tests that ensures literal values are not sanitized in dev * Use `{color:false,depth:null}` options for formatting everywhere * Prettier format * Fix property name typo `color`->`colors` and helper function call * Move changelog entries from added to changed section --------- Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com> * fix: GraphiQL Explorer Plugin CDN URL (#101) * Fix GraphiQL explorer plugin CDN URL * Add changelog entry * prepare 0.6.1 hotfix (#102) * prepare 0.6.1 hotfix * 0.6.1 in package.json --------- Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dist filename of the GraphiQL Explorer Plugin changed upstream causing the CDN URL to need to be adjusted.
See: https://github.com/graphql/graphiql/releases/tag/%40graphiql%2Fplugin-explorer%400.2.0