feat(logging): enhanced error logging capabilities #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all errors were logged as generic errors. This enhancement introduces selective logging of warnings and errors based on their error type. Additionally, message interpolation has been introduced to resolve error message placeholders into human-readable text.
schwma
reviewed
Nov 8, 2023
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
schwma
previously requested changes
Nov 9, 2023
schwma
requested changes
Nov 9, 2023
Member
schwma
left a comment
schwma
left a comment
There was a problem hiding this comment.
Could you please add a changelog entry? Also, are stacktraces logged?
arleytm
changed the title
Contributor
Author
changelog added. Stack traces are logged. |
schwma
requested changes
Nov 13, 2023
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
schwma
requested changes
Nov 14, 2023
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
schwma
changed the title
schwma
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all errors were logged as generic errors. This enhancement introduces selective logging of warnings and errors based on their error type. Errors representing client errors (
4xxrange) are now logged as warnings instead of errors.Additionally, message interpolation has been introduced to resolve error message placeholders into human-readable text.