refactor: use GraphQL Type APIs instead of internal properties #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hm23
approved these changes
Jan 11, 2023
johannes-vogel
added a commit
that referenced
this pull request
Jan 30, 2023
* Add repo url to point to a git project (#24) * update home page to point to a git project * Revert "update home page to point to a git project" This reverts commit dc05c23. * provide repository.url in package.json * package.json formatting * docs: prepare changelog for next release (#21) * fix: server crash if "localized" is used as property name (#26) * fix: server crash if "localized" is used as property name * Update lib/schema/util/index.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * Review Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * test: lower timestamp precision for now (#28) * feat: register alias field resolver in schema generation (#31) * Register aliasFieldResolver in schema generation * Add changelog entry * Change changelog entry wording * refactor: use GraphQL Type APIs instead of internal properties (#29) * refactor: use GraphQL Type APIs instead of internal properties * Use Type API in test util * refactor: make root resolver a named function (#33) * chore: simplified protocols config (#27) * Simplified config * Rm unneeded middlewares config from package.jsons * Move server.js up one level into project roots * Remove unused server.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * chore: add CODEOWNERS file for automated PR reviewer assignment (#34) * style: enable prettier to format inline queries (#35) * Add dummy gql tag for query formatting and syntax highlighting * Prettier format * feat: replace `like` with CQN function calls (#36) * replace like with contains func * formating * Cleanup and use CQN functions for startswith and endsWith * Rm helper function * Add changelog entry * Improve wording Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * fix: query `totalCount` on its own (#38) * Add test querying only totalCount * Check if is connection from selected field names * Add changelog entry * Use gql tag in test * Use ternary conditional operator * chore: miscellaneous cleanup (#37) * Fix folder name util.js -> util * Fix typo * Fix comment * Simplify repository in package.json * Move jest configuration out of package.json * Remove "Release" prefix from release title * Remove unneeded else * Remove managed from localized test * Rm space * docs: improve CHANGELOG wording (#39) * add changelog and release date (#40) --------- Co-authored-by: Petr Plenkov <petr.plenkov@gmail.com> Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> Co-authored-by: Robert Witt <46402879+robertwitt@users.noreply.github.com> Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com> Co-authored-by: Lars Lutz <56645452+larslutz96@users.noreply.github.com>
johannes-vogel
added a commit
that referenced
this pull request
Feb 27, 2023
* Add repo url to point to a git project (#24) * update home page to point to a git project * Revert "update home page to point to a git project" This reverts commit dc05c23. * provide repository.url in package.json * package.json formatting * docs: prepare changelog for next release (#21) * fix: server crash if "localized" is used as property name (#26) * fix: server crash if "localized" is used as property name * Update lib/schema/util/index.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * Review Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * test: lower timestamp precision for now (#28) * feat: register alias field resolver in schema generation (#31) * Register aliasFieldResolver in schema generation * Add changelog entry * Change changelog entry wording * refactor: use GraphQL Type APIs instead of internal properties (#29) * refactor: use GraphQL Type APIs instead of internal properties * Use Type API in test util * refactor: make root resolver a named function (#33) * chore: simplified protocols config (#27) * Simplified config * Rm unneeded middlewares config from package.jsons * Move server.js up one level into project roots * Remove unused server.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * chore: add CODEOWNERS file for automated PR reviewer assignment (#34) * style: enable prettier to format inline queries (#35) * Add dummy gql tag for query formatting and syntax highlighting * Prettier format * feat: replace `like` with CQN function calls (#36) * replace like with contains func * formating * Cleanup and use CQN functions for startswith and endsWith * Rm helper function * Add changelog entry * Improve wording Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * fix: query `totalCount` on its own (#38) * Add test querying only totalCount * Check if is connection from selected field names * Add changelog entry * Use gql tag in test * Use ternary conditional operator * chore: miscellaneous cleanup (#37) * Fix folder name util.js -> util * Fix typo * Fix comment * Simplify repository in package.json * Move jest configuration out of package.json * Remove "Release" prefix from release title * Remove unneeded else * Remove managed from localized test * Rm space * docs: improve CHANGELOG wording (#39) * add changelog and release date (#40) * docs: prepare next release (#42) * docs: prepare changelog for next release * Bump version in package.json * feat: replace `express-graphql` with `graphql-http` (#43) * Replace express-graphql with graphql-http server * Bump graphql-http version * Add graphiql * Bump graphql-http version (includes errors fix) * Bump graphql version to 16 * Bump graphql-http version * Add changelog entries * Add changelog entry for graphql version bump * feat: resolver concurrency (#32) * feat: resolver concurrency * Fix merge errors * Use gql tag in concurrency tests * Move requires into describe block * Add axios validateStatus false * Get axios from cds.test * Simplify middlewares config * Await all promises in root resolver * Move tests to describe block * Add tests for resolvers that return data and error * Handle thrown non-Error object values * Extract _getAndSetResponse function * Split getting and setting of response * Move setResponse to util module * Remove unneeded argument due to closure * Move changelog entry to correct release * update changelog for 0.3.0 and add release date (#44) * build: parse `CHANGELOG` and add entries to GitHub release body (#45) * Add changelog parsing to release workflow * Move id before uses --------- Co-authored-by: Petr Plenkov <petr.plenkov@gmail.com> Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> Co-authored-by: Robert Witt <46402879+robertwitt@users.noreply.github.com> Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com> Co-authored-by: Lars Lutz <56645452+larslutz96@users.noreply.github.com>
schwma
added a commit
that referenced
this pull request
Feb 28, 2023
* Add repo url to point to a git project (#24) * update home page to point to a git project * Revert "update home page to point to a git project" This reverts commit dc05c23. * provide repository.url in package.json * package.json formatting * docs: prepare changelog for next release (#21) * fix: server crash if "localized" is used as property name (#26) * fix: server crash if "localized" is used as property name * Update lib/schema/util/index.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * Review Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * test: lower timestamp precision for now (#28) * feat: register alias field resolver in schema generation (#31) * Register aliasFieldResolver in schema generation * Add changelog entry * Change changelog entry wording * refactor: use GraphQL Type APIs instead of internal properties (#29) * refactor: use GraphQL Type APIs instead of internal properties * Use Type API in test util * refactor: make root resolver a named function (#33) * chore: simplified protocols config (#27) * Simplified config * Rm unneeded middlewares config from package.jsons * Move server.js up one level into project roots * Remove unused server.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * chore: add CODEOWNERS file for automated PR reviewer assignment (#34) * style: enable prettier to format inline queries (#35) * Add dummy gql tag for query formatting and syntax highlighting * Prettier format * feat: replace `like` with CQN function calls (#36) * replace like with contains func * formating * Cleanup and use CQN functions for startswith and endsWith * Rm helper function * Add changelog entry * Improve wording Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * fix: query `totalCount` on its own (#38) * Add test querying only totalCount * Check if is connection from selected field names * Add changelog entry * Use gql tag in test * Use ternary conditional operator * chore: miscellaneous cleanup (#37) * Fix folder name util.js -> util * Fix typo * Fix comment * Simplify repository in package.json * Move jest configuration out of package.json * Remove "Release" prefix from release title * Remove unneeded else * Remove managed from localized test * Rm space * docs: improve CHANGELOG wording (#39) * add changelog and release date (#40) * docs: prepare next release (#42) * docs: prepare changelog for next release * Bump version in package.json * feat: replace `express-graphql` with `graphql-http` (#43) * Replace express-graphql with graphql-http server * Bump graphql-http version * Add graphiql * Bump graphql-http version (includes errors fix) * Bump graphql version to 16 * Bump graphql-http version * Add changelog entries * Add changelog entry for graphql version bump * feat: resolver concurrency (#32) * feat: resolver concurrency * Fix merge errors * Use gql tag in concurrency tests * Move requires into describe block * Add axios validateStatus false * Get axios from cds.test * Simplify middlewares config * Await all promises in root resolver * Move tests to describe block * Add tests for resolvers that return data and error * Handle thrown non-Error object values * Extract _getAndSetResponse function * Split getting and setting of response * Move setResponse to util module * Remove unneeded argument due to closure * Move changelog entry to correct release * update changelog for 0.3.0 and add release date (#44) * build: parse `CHANGELOG` and add entries to GitHub release body (#45) * Add changelog parsing to release workflow * Move id before uses * chore: prepare next release (#47) * fix: include app folder in package.json * Add changelog entry * chore: prepare release 0.3.1 (#52) --------- Co-authored-by: Petr Plenkov <petr.plenkov@gmail.com> Co-authored-by: Robert Witt <46402879+robertwitt@users.noreply.github.com> Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com> Co-authored-by: Lars Lutz <56645452+larslutz96@users.noreply.github.com> Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com> Co-authored-by: Dr. David A. Kunz <david.kunz@sap.com>
johannes-vogel
added a commit
that referenced
this pull request
Mar 29, 2023
* Add repo url to point to a git project (#24) * update home page to point to a git project * Revert "update home page to point to a git project" This reverts commit dc05c23. * provide repository.url in package.json * package.json formatting * docs: prepare changelog for next release (#21) * fix: server crash if "localized" is used as property name (#26) * fix: server crash if "localized" is used as property name * Update lib/schema/util/index.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * Review Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * test: lower timestamp precision for now (#28) * feat: register alias field resolver in schema generation (#31) * Register aliasFieldResolver in schema generation * Add changelog entry * Change changelog entry wording * refactor: use GraphQL Type APIs instead of internal properties (#29) * refactor: use GraphQL Type APIs instead of internal properties * Use Type API in test util * refactor: make root resolver a named function (#33) * chore: simplified protocols config (#27) * Simplified config * Rm unneeded middlewares config from package.jsons * Move server.js up one level into project roots * Remove unused server.js Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * chore: add CODEOWNERS file for automated PR reviewer assignment (#34) * style: enable prettier to format inline queries (#35) * Add dummy gql tag for query formatting and syntax highlighting * Prettier format * feat: replace `like` with CQN function calls (#36) * replace like with contains func * formating * Cleanup and use CQN functions for startswith and endsWith * Rm helper function * Add changelog entry * Improve wording Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> * fix: query `totalCount` on its own (#38) * Add test querying only totalCount * Check if is connection from selected field names * Add changelog entry * Use gql tag in test * Use ternary conditional operator * chore: miscellaneous cleanup (#37) * Fix folder name util.js -> util * Fix typo * Fix comment * Simplify repository in package.json * Move jest configuration out of package.json * Remove "Release" prefix from release title * Remove unneeded else * Remove managed from localized test * Rm space * docs: improve CHANGELOG wording (#39) * add changelog and release date (#40) * docs: prepare next release (#42) * docs: prepare changelog for next release * Bump version in package.json * feat: replace `express-graphql` with `graphql-http` (#43) * Replace express-graphql with graphql-http server * Bump graphql-http version * Add graphiql * Bump graphql-http version (includes errors fix) * Bump graphql version to 16 * Bump graphql-http version * Add changelog entries * Add changelog entry for graphql version bump * feat: resolver concurrency (#32) * feat: resolver concurrency * Fix merge errors * Use gql tag in concurrency tests * Move requires into describe block * Add axios validateStatus false * Get axios from cds.test * Simplify middlewares config * Await all promises in root resolver * Move tests to describe block * Add tests for resolvers that return data and error * Handle thrown non-Error object values * Extract _getAndSetResponse function * Split getting and setting of response * Move setResponse to util module * Remove unneeded argument due to closure * Move changelog entry to correct release * update changelog for 0.3.0 and add release date (#44) * build: parse `CHANGELOG` and add entries to GitHub release body (#45) * Add changelog parsing to release workflow * Move id before uses * chore: prepare next release (#47) * fix: include app folder in package.json * Add changelog entry * chore: prepare release 0.3.1 (#52) * chore: prepare next release (#55) * fix: `GET` requests with `query` parameter if GraphiQL is enabled (#56) * Allow GET requests with query parameter while GraphiQL is served * Extract GraphiQL router to separate module * Add tests for GraphiQL * Add app folder to prettier * Add changelog entry * Simplify path to graphiql.html * Simplify formatting * feat: `null` and `undefined` values in arguments and empty input objects and lists in filters (#25) * Prettier format * Add tests for null and undefined values in args * Ignore arguments with values of null * Improve check if literal is a scalar to be parsed * Replace variable null values with AST NullValues * Add convenience AST NullValue value * Substitute undefined variables with undefined * Ignore arguments with undefined variable values * Add changelog entries * Use gql tag in null/undefined tests * Move changelog entries to newest release * Ignore undefined properties in filter objects * Ignore incomplete filters like `{ ID: { stock: null } }` * Don't check if parseLiteral function is defined * Add tests combining undefined/null and non-undefined/non-null variable values * Prettier format * Create false _xpr for empty filter lists * Adjust tests so that incomplete filters return no results * Also adjust tests without connections * Empty filter objects return true _xprs * Adjust tests so that incomplete filters are ignored * Remove empty describe block * Move up filter leaf guard clause * Remove duplicated tests * Remove insert from variables test * Add tests for empty filter structures joined with equality filters * Add changelog entry * Split filter tests into two describe blocks * Using new `cds-plugin` technique (#59) * prepare changelog for release (#60) @schwma I think you'd also like to include #58, don't you? * feat: filters using the same operator on the same field joined by `AND` (#58) * Add test for filter joined by AND on the same field with the same operator * Add list to allow for AND filters on the same column with the same operator * Add changelog entry * Remove comment from example query --------- Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com> * Update repository in package.json (#62) --------- Co-authored-by: Petr Plenkov <petr.plenkov@gmail.com> Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> Co-authored-by: Robert Witt <46402879+robertwitt@users.noreply.github.com> Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com> Co-authored-by: Lars Lutz <56645452+larslutz96@users.noreply.github.com> Co-authored-by: Dr. David A. Kunz <david.kunz@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.