[FEATURE!] Disable Conjunction for Certain Operators #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apter
This PR enables conjunction for specific operators in the CAP GraphQL Adapter, allowing for combining multiple
conditions in queries. The proposed configuration has been refined based on team discussions and stakeholders and
incorporates valuable input from all members. The final decision ensures a balanced approach, considering use cases
and potential conflicts.
Changes Made:
- Updated the configuration in the CAP GraphQL Adapter to enable conjunction for the following operators:
- `ne` (Not Equal)
- `contains`
- Disabled conjunction for the following operators:
- `eq` (Equal)
- `gt` (Greater Than)
- `ge` (Greater Than or Equal)
- `le` (Less Than or Equal)
- `lt` (Less Than)
- `startswith`
- `endswith`
Sample using `contains`:
query MyQuery {
AdminService {
Books(filter: {title: {contains: ["Wuthering", "Heights"]}}) {
nodes {
title
}
}
}
}
Reasoning:
- Enabling conjunction for `ne` and `contains` allows combining multiple inequality and string condition in queries,
providing greater flexibility.
- Disabling conjunction for other operators simplifies the query evaluation process. When multiple values are provided
for operators such as `eq`, `gt`, `ge`, `le`, `lt`, only the lowest or highest value in the list will be considered,
making the other values without effect. By disabling conjunction for these operators, the query can be simplified to a
single value without evaluating additional values, enhancing query performance and reducing complexity.
arleytm
changed the title
schwma
requested changes
Jun 13, 2023
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com>
schwma
approved these changes
Jun 13, 2023
Member
schwma
left a comment
schwma
left a comment
There was a problem hiding this comment.
Thanks for the changes, LGTM 👍
Maybe we should still wait for @johannes-vogel approval of the proposal before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables conjunction for specific operators in the CAP GraphQL Adapter, allowing for combining multiple conditions in queries. The proposed configuration has been refined based on team discussions and stakeholders and incorporates valuable input from all members.
Changes Made
Updated the configuration to enable conjunction for the following operators
ne(Not Equal)containsDisabled conjunction for the following operators
eq(Equal)gt(Greater Than)ge(Greater Than or Equal)le(Less Than or Equal)lt(Less Than)startswithendswithSample query using
containsoperator as a filterReasoning
neandcontainsallows combining multiple inequality and string condition in queries, providing greater flexibility.eq,gt,ge,le,lt, only the lowest or highest value in the list will be considered, making the other values without effect. By disabling conjunction for these operators, the query can be simplified to a single value without evaluating additional values, enhancing query performance and reducing complexity.