[SDMEXT-590] Display attachments specific to repository #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using { Attachments} from '@cap-js/attachments'; | ||
| extend aspect Attachments with { | ||
| folderId : String @title: 'Folder ID' @readonly; | ||
| repositoryId : String @title: 'Repository ID' @readonly default null; |
There was a problem hiding this comment.
make this as Hidden
…s://github.com/cap-js/sdm into SDMEXT-590/readAttachmentsSpecificToRepository
rashmiangadi11
approved these changes
Jan 22, 2025
yashmeet29
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the check for repository ID, so that the user does not see attachments that were uploaded to a different repository, than the one with which the application is currently deployed. It also fixes the bug when using multiple repositories, if the application is deployed with a repository and an entity is created with a few attachments in them, a folder is created for that entity in the repository. When deployed with a different repository, it will find the folderId from the db and try to create attachments in it, but it will fail as the folder was created with a different repository. This is resolved by adding a repositoryId check while looking for folder. It also modifies the duplicate file check to check only in the current repository.
JIRA BL : SDMEXT-590