chore: guard against cds10 until prepped#418
Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
The single substantive issue in this PR is the unintentionally restrictive ^0 range for @cap-js/cds-test: unlike the other packages (which had explicit major-version upper bounds worth tightening), ^0 will exclude any 1.x+ release of that package that may already exist or ship in the future — which is almost certainly not the intended behaviour given the PR's stated goal of guarding only against cds@10. The rest of the changes (^8 || ^9, ^1 || ^2, ^2 || ^3) are correct semver ranges for the stated purpose.
PR Bot Information
Version: 1.20.33
- File Content Strategy: Full file content
- Correlation ID:
d038cf21-0707-45ec-b548-214367285b6b - LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened
| "devDependencies": { | ||
| "@cap-js/cds-test": ">=0", | ||
| "@cap-js/sqlite": ">=1", | ||
| "@cap-js/cds-test": "^0", |
There was a problem hiding this comment.
Logic Error: ^0 blocks all stable releases of @cap-js/cds-test
The ^0 range in npm semver has special behaviour: when the major version is 0, the caret operator only allows patch-level changes (0.x.y → 0.x.*). More critically, ^0 is equivalent to >=0.0.0 <1.0.0 — it excludes any 1.x or later release. The previous >=0 was intentional to allow any release regardless of major version.
If the goal here (matching the rest of the PR) is to guard against a future breaking major while still allowing all current stable versions, the range should explicitly enumerate the known-good majors, or simply remain >=0 if no upper guard is needed for this package.
| "@cap-js/cds-test": "^0", | |
| "@cap-js/cds-test": ">=0", |
Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
Guard Against CDS 10 by Restricting Peer Dependency Version Range
Chore
🔧 Updated the
@sap/cdspeer dependency version range inpackage.jsonto explicitly exclude CDS version 10 until the package is prepared to support it. Related dev dependency version ranges were also tightened for consistency.Changes
package.json:@sap/cdspeer dependency from>=8to^8 || ^9, preventing accidental resolution to CDS 10.@cap-js/cds-testdev dependency from>=0to^0.@cap-js/sqlitedev dependency from>=1to^1 || ^2.@sap/cds-mtxsdev dependency from>=2to^2 || ^3.PR Bot Information
Version:
1.20.33anthropic--claude-4.6-sonnetd038cf21-0707-45ec-b548-214367285b6bpull_request.opened