New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t generate binstubs by default #61

Merged
merged 1 commit into from Jan 22, 2015

Conversation

Projects
None yet
3 participants
@kirs
Member

kirs commented Jan 12, 2015

Two reasons:

  1. bin/ is often checked out into repo
  2. #45 (comment)
Don’t generate binstubs by default
Two reasons:
1) `bin/` is often checked out into repo
2) #45 (comment)
@kirs

This comment has been minimized.

Show comment
Hide comment
@kirs
Member

kirs commented Jan 12, 2015

/cc @indirect

@Kriechi

This comment has been minimized.

Show comment
Hide comment
@Kriechi

Kriechi Jan 12, 2015

Contributor

👍
I'm using that a long time now for all my deployments.

Contributor

Kriechi commented Jan 12, 2015

👍
I'm using that a long time now for all my deployments.

kirs added a commit that referenced this pull request Jan 22, 2015

Merge pull request #61 from capistrano/no-default-binstubs
Don’t generate binstubs by default

@kirs kirs merged commit dc0d93d into master Jan 22, 2015

@kirs

This comment has been minimized.

Show comment
Hide comment
@kirs

kirs Jan 22, 2015

Member

1.1.4 released.

Member

kirs commented Jan 22, 2015

1.1.4 released.

roback added a commit to twingly/capistrano-twingly that referenced this pull request Feb 16, 2015

Enable bundle_binstubs manually
The deploy failed when trying to export the upstart script.

The default behaviour changed in capistrano-bundler here:
capistrano/bundler#61
@rmetzler

This comment has been minimized.

Show comment
Hide comment
@rmetzler

rmetzler Apr 15, 2015

Oh damn, I was bitten by this one. I think it is a breaking change and it should have used minor version bump and not a patch version number bump according to semver.

I use the whenever gem which creates cron jobs and uses the release path to find the binstubs. I also had working binstubs until updating. Now my binstubs didn't get updated and when capistrano removed the old releases all my binstubs (e.g. bin/rails runner) ran into "path not found" errors.

rmetzler commented Apr 15, 2015

Oh damn, I was bitten by this one. I think it is a breaking change and it should have used minor version bump and not a patch version number bump according to semver.

I use the whenever gem which creates cron jobs and uses the release path to find the binstubs. I also had working binstubs until updating. Now my binstubs didn't get updated and when capistrano removed the old releases all my binstubs (e.g. bin/rails runner) ran into "path not found" errors.

@Kriechi

This comment has been minimized.

Show comment
Hide comment
@Kriechi

Kriechi Apr 15, 2015

Contributor

Are your binstubs not checked into your version control system?
They should... because then they are just part of every new deploy.

Contributor

Kriechi commented Apr 15, 2015

Are your binstubs not checked into your version control system?
They should... because then they are just part of every new deploy.

@rmetzler

This comment has been minimized.

Show comment
Hide comment
@rmetzler

rmetzler Apr 15, 2015

Thanks for hint. I usually just use bundle exec and don't use binstubs on my dev machine. I also wasn't aware that whenever uses binstubs.

rmetzler commented Apr 15, 2015

Thanks for hint. I usually just use bundle exec and don't use binstubs on my dev machine. I also wasn't aware that whenever uses binstubs.

@Kriechi

This comment has been minimized.

Show comment
Hide comment
@Kriechi

Kriechi Apr 15, 2015

Contributor

Well that was the idea of binstubs - to get rid of bundle exec confusion.
Therefore it makes sense for whenever to use them.

Just generate them properly, add them to git, and never touch them again.

Contributor

Kriechi commented Apr 15, 2015

Well that was the idea of binstubs - to get rid of bundle exec confusion.
Therefore it makes sense for whenever to use them.

Just generate them properly, add them to git, and never touch them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment