Permalink
Commits on Oct 19, 2018
  1. Merge pull request #1997 from NikolayRys/test-output-cleanup

    will-in-wi committed Oct 19, 2018
    Silence console output during the tests
  2. Silence console output in tests

    NikolayRys committed Oct 19, 2018
    * Rspec callback that assigns IO objects to collect and silence all output of the SUT and Rake, driven by example metadata.
    * Consistent cleanup in the test for print-config-variables option.
    * Requiring necessary lib, which was missing in scm-resolver spec file.
Commits on Oct 12, 2018
  1. Merge pull request #2005 from berkes/feature/dead-link

    will-in-wi committed Oct 12, 2018
    Remove dead link from the sidebar.
  2. Remnove dead link from the sidebar.

    berkes committed Oct 12, 2018
    Site is gone and the content seems lost. If someone has a mirror, that
    could be re-added.
Commits on Oct 9, 2018
  1. Merge pull request #2003 from phallstrom/local_user_docs

    mattbrictson committed Oct 9, 2018
    Update docs to reflect true default for :local_user
Commits on Oct 8, 2018
  1. Update docs to reflect true default for :local_user

    phallstrom committed Oct 8, 2018
    A change was made to the default for :local_user in
    
    d947b25
    
    The docs weren't updated to reflect the new reality. They are now.
Commits on Oct 7, 2018
  1. Update docs gems

    will-in-wi committed Oct 7, 2018
Commits on Jul 5, 2018
  1. Merge pull request #1995 from aeroastro/feature/avoid-using-string

    mattbrictson committed Jul 5, 2018
    Simplify code on removing old directories by skipping `Array#join`
  2. Simplify code on removing old directories by skipping `Array#join`

    aeroastro committed Jul 5, 2018
    `execute(*)` provided by SSHKit internally joins arguments with space
    for the command to be executed. As it is the responsibility of SSHKit,
    we can skip the code at Capistrano layer.
Commits on Jun 24, 2018
  1. Merge pull request #1992 from will-in-wi/https_docs

    will-in-wi committed Jun 24, 2018
    Switch a number of http links and dependencies to https
Commits on Jun 21, 2018
  1. Merge pull request #1988 from capistrano/upgrade-all-docs

    will-in-wi committed Jun 21, 2018
    Upgrade all docs gems
Commits on Jun 20, 2018
  1. Upgrade all docs gems

    will-in-wi committed Jun 20, 2018
  2. Merge pull request #1987 from capistrano/upgrade_docs_nokogiri

    leehambley committed Jun 20, 2018
    Upgrade Nokogiri for security
  3. Upgrade Nokogiri for security

    will-in-wi committed Jun 20, 2018
Commits on Jun 19, 2018
  1. Merge pull request #1985 from capistrano/fix-travis-for-old-ruby-and-…

    mattbrictson committed Jun 19, 2018
    …net-ssh
    
    Fix travis for older rubies
Commits on Jun 18, 2018
  1. Add latest rubies to Travis

    mattbrictson committed Jun 18, 2018
Commits on Jun 3, 2018
  1. Preparing v3.11.0

    mattbrictson committed Jun 3, 2018
Commits on May 30, 2018
  1. feat: fallback ask to default when in non interactive run

    salzig authored and mattbrictson committed Mar 28, 2018
Commits on Apr 15, 2018
  1. Preparing v3.10.2

    mattbrictson committed Apr 15, 2018
Commits on Apr 13, 2018
  1. There should not be an instance where a git revision should be append…

    mmiller1 authored and mattbrictson committed Apr 13, 2018
    …ed (#1977)
    
    * There should not be an instance where a git revision should be appended
    here
    
    * changelog
Commits on Apr 3, 2018
  1. Merge pull request #1975 from capistrano/fix-any-arity-test-failure

    will-in-wi committed Apr 3, 2018
    Fix intermittent test failure due to any? DSL
Commits on Mar 29, 2018
  1. Fix intermittent test failure due to any? DSL

    mattbrictson committed Mar 29, 2018
    Capistrano's `any?` DSL method, as a convenience, will delegate a zero-
    arity call to `any?` for the object stored in the variable that is being
    interrogated. For example, `any?(:ssh_options)` will first fetch the
    value of the variable `:ssh_options`, and then call `any?` on it with
    zero arguments.
    
    The bug stems from the fact that we were not checking the arity of
    `any?` before calling it. So if the object being interrogated has an
    `any?` method that requires an argument, the method invocation will fail
    with an `ArgumentError`.
    
    For whatever reason, under certain circumstances related to test order,
    the stub object provided by Rspec would sometimes have an `any?` method
    on it (inherited from `Capistrano::DSL`) that required an argument.
    Hence we would occasionally see test failures.
    
    There isn't a reliable way to check the arity of `any?` (it is `-1` for
    forwarded or native methods), so the fix is to simply rescue the
    `ArgumentError` and fallback to non-`any?` behavior.
Commits on Feb 1, 2018
  1. Merge pull request #1964 from capistrano/require-false

    will-in-wi committed Feb 1, 2018
    Recommend `require: false` in Gemfile
  2. Recommend `require: false` in Gemfile

    mattbrictson committed Feb 1, 2018
    Capistrano gems shouldn't be loaded within a Rails (or any) app. They
    are intended to be used by the cap command, not within Rails itself. At
    best, `require: true` (the default) is unnecessary; at worst, it can
    cause conflicts as encountered here:
    
    https://stackoverflow.com/q/48493332/4625365
    
    Update our docs to recommend `require: false` just to be safe.
Commits on Jan 7, 2018
  1. Merge pull request #1960 from capistrano/happy-new-year

    will-in-wi committed Jan 7, 2018
    Happy new year! 🎊
Commits on Jan 4, 2018
  1. Merge pull request #1959 from uuushiro/fix-template-comment

    mattbrictson committed Jan 4, 2018
    remove comment about secrets
Commits on Dec 8, 2017
  1. Preparing v3.10.1

    mattbrictson committed Dec 8, 2017
Commits on Nov 27, 2017
  1. Merge pull request #1954 from rjwalsh88/fix-host-filter-regex

    mattbrictson committed Nov 27, 2017
    HostFilter: Fix regex for multi-host strings
  2. HostFilter: Fix regex for multi-host strings

    RJ Walsh
    RJ Walsh committed Nov 27, 2017
    #1928 introduced a
    small bug in regex generation for multi-host strings, e.g.:
    
    ```
    HOSTS=server1.com,server2.com bundle exec cap production deploy
    ```
    
    This would be parsed and split correctly, however:
    
    ```
    HOSTS=server9.com,server10.com bundle exec cap production deploy
    ```
    
    would deploy to no hosts, because of the `0` in the hostname.
    
    This commit fixes the regular expression used to split multi-host
    strings, and updates the test suite to include `0` in the test
    cases.
Commits on Oct 26, 2017
  1. Merge pull request #1948 from InFog/colours_custom_filters

    mattbrictson committed Oct 26, 2017
    Fixed the highlight on the custom filters page.