File Transfer methods put() and upload() don't honor dry-run flag

[benissimo]

https://github.com/capistrano/capistrano/blob/master/lib/capistrano/configuration/actions/file_transfer.rb

transfer() honors the dry-run flag.
upload() (and put() which is a wrapper around upload()) doesn't.

This is why, for example, deploy:web:disable doesn't honor the dry-run flag:
#151

But more generally, any task built on put() or upload() will fail to honor the dry-run flag.

[shtirlic]

All methods like put get upload download are using the transfer method which honors dry-run flag as you could see in this line of code https://github.com/capistrano/capistrano/blob/master/lib/capistrano/configuration/actions/file_transfer.rb#L40
But the execute_on_servers actually connecting to the all servers and will not harm to servers.

[benissimo]

My mistake, thanks for correcting me. I guess it's the fact that it does actually try to connect to the remote servers which threw me. As you noted, transfer does still invoke "execute_on_servers", even in dry-run. Whereas instead "run()" bails out before calling "execute_on_servers" in dry-run mode. The discrepancy between the two is most noticeable when alternating between deploy:web:enable and deploy:web:disable, both with dry-run. One simply prints out the command it would have tried, the other also attempts to connect to the remote servers. In my opinion it would be a good practice for dry-run to always imply skipping execute_on_servers. I see from the line you cited above that it would not actually try to do anything once connected to the remote servers. Still, I feel a dry run should not even connect to the servers. Alternatively, if connecting to the servers is deemed as something to be included in a dry run, it would be clearer if that occurred in all cases (run() as well as transfer()).

[shtirlic]

Ok, I got your point, I also think that result should be the same in both cases, I''ll try to come up with a patch for the transfer method.

[benissimo]

Thanks!

[shtirlic]

I submitted my pull request as #167