New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 support #362

Closed
ai opened this Issue Jan 19, 2013 · 14 comments

Comments

Projects
None yet
@ai

ai commented Jan 19, 2013

Rails 4 store manifest in JSON file like manifest-effbd5715fcc7c1600baa48c1bc283ee.json, not in manifest.yml. So right now we can’t deploy Rails 4 application.

@ai

This comment has been minimized.

Show comment
Hide comment
@ai

ai Jan 19, 2013

I create really dirty hack to support Rails 4, if anybody will need fast fix: ai/capistrano rails4.

ai commented Jan 19, 2013

I create really dirty hack to support Rails 4, if anybody will need fast fix: ai/capistrano rails4.

@rizwanreza

This comment has been minimized.

Show comment
Hide comment
@rizwanreza

rizwanreza commented Feb 3, 2013

+1

@gogolok

This comment has been minimized.

Show comment
Hide comment
@gogolok

gogolok Feb 4, 2013

Yeah, Rails 4 support is broken in master :-(

gogolok commented Feb 4, 2013

Yeah, Rails 4 support is broken in master :-(

@martijn

This comment has been minimized.

Show comment
Hide comment
@martijn

martijn Feb 6, 2013

+1, deploy/assets definitely needs some love

martijn commented Feb 6, 2013

+1, deploy/assets definitely needs some love

@martijn

This comment has been minimized.

Show comment
Hide comment
@martijn

martijn Feb 6, 2013

This patch by @diragor looks reasonable: diragor@9307c30

martijn commented Feb 6, 2013

This patch by @diragor looks reasonable: diragor@9307c30

@diragor

This comment has been minimized.

Show comment
Hide comment
@diragor

diragor Feb 6, 2013

My patch hasn't had much testing yet, I'm trying to find the time to finish it up. In the meantime, we're deploying with the last cap commit before all the asset manifest stuff was added, like so:

gem 'capistrano', github: 'capistrano/capistrano', ref: '96a16'

diragor commented Feb 6, 2013

My patch hasn't had much testing yet, I'm trying to find the time to finish it up. In the meantime, we're deploying with the last cap commit before all the asset manifest stuff was added, like so:

gem 'capistrano', github: 'capistrano/capistrano', ref: '96a16'

@cmaitchison

This comment has been minimized.

Show comment
Hide comment
@cmaitchison

cmaitchison Feb 27, 2013

This fixes Rails 4 for me. It is quite simple because the manifest.json is now in public/assets, not public. This means nothing needs to be copied around.

namespace :deploy do
  namespace :assets do
    task :precompile, :roles => assets_role, :except => { :no_release => true } do
      run <<-CMD.compact
        cd -- #{latest_release.shellescape} &&
        #{rake} RAILS_ENV=#{rails_env.to_s.shellescape} #{asset_env} assets:precompile
      CMD
    end
  end
end

cmaitchison commented Feb 27, 2013

This fixes Rails 4 for me. It is quite simple because the manifest.json is now in public/assets, not public. This means nothing needs to be copied around.

namespace :deploy do
  namespace :assets do
    task :precompile, :roles => assets_role, :except => { :no_release => true } do
      run <<-CMD.compact
        cd -- #{latest_release.shellescape} &&
        #{rake} RAILS_ENV=#{rails_env.to_s.shellescape} #{asset_env} assets:precompile
      CMD
    end
  end
end
@tony612

This comment has been minimized.

Show comment
Hide comment
@tony612

tony612 Feb 28, 2013

+1, and I want to know, is it fixed?

tony612 commented Feb 28, 2013

+1, and I want to know, is it fixed?

@stamm

This comment has been minimized.

Show comment
Hide comment
@stamm

stamm Mar 6, 2013

Contributor

+1

Contributor

stamm commented Mar 6, 2013

+1

@josemotanet

This comment has been minimized.

Show comment
Hide comment
@josemotanet

josemotanet Mar 6, 2013

I am also interested in a fix for this. Installed capistrano yesterday and I'm unable to deploy with Rails 4 beta 1.

josemotanet commented Mar 6, 2013

I am also interested in a fix for this. Installed capistrano yesterday and I'm unable to deploy with Rails 4 beta 1.

@ai

This comment has been minimized.

Show comment
Hide comment
@ai

ai Mar 13, 2013

Thanks @jimryan! When his pull request will be accepted?

ai commented Mar 13, 2013

Thanks @jimryan! When his pull request will be accepted?

@simonoff

This comment has been minimized.

Show comment
Hide comment
@simonoff

simonoff Mar 25, 2013

Any updates?

simonoff commented Mar 25, 2013

Any updates?

@jp

This comment has been minimized.

Show comment
Hide comment
@jp

jp Apr 2, 2013

+1, thanks @cmaitchison for your workaround.

jp commented Apr 2, 2013

+1, thanks @cmaitchison for your workaround.

@leehambley

This comment has been minimized.

Show comment
Hide comment
@leehambley

leehambley Apr 2, 2013

Member

WIP in #412. Closing this issue as work will be tracked in the pull request that @jimryan is smashing for us! 🚀

Member

leehambley commented Apr 2, 2013

WIP in #412. Closing this issue as work will be tracked in the pull request that @jimryan is smashing for us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment