Skip to content

3.1 release TODO #813

Closed
kirs opened this Issue Nov 28, 2013 · 16 comments

6 participants

@kirs
Capistrano member
kirs commented Nov 28, 2013
  • As :restart is not invoked on deploy, I've run into a problem after upgrading 3.0.1 to 3.1. I forgot to add after :publishing, :restart and my Puma didn't restart :( I think we really should notify users about that somehow.
  • release doc should describe that 3.0 had issues with mapping rbenv/rvm/bundler commands and this was totally fixed in 3.1
  • don't forget to mention @Kriechi 's help
@kirs
Capistrano member
kirs commented Nov 28, 2013
@leehambley
Capistrano member

Agreed 3/3.

@seenmyfate
Capistrano member

@kirs @leehambley I've updated the Changelog to cover today's merges, do you want to add the points above? Other than these notes as far as I'm concerned master is ready to release.

@seenmyfate
Capistrano member

We should also release updated versions of bundler, rails and rbenv following changes to the dependency requirements today.

@kirs
Capistrano member
kirs commented Dec 20, 2013

I'm afraid that 90% of developers don't ready CHANGELOG after gem update. What you thing about post_install_message from rubygems?

I mean not to copy paste the content there, just to announce the url with changes.

@leehambley
Capistrano member
@kirs kirs added a commit to kirs/capistrano that referenced this issue Jan 3, 2014
@kirs kirs Capistrano 3.1 post_install_message #813 0b511e3
@Kriechi
Kriechi commented Jan 3, 2014

@leehambley and @seenmyfate: did you decide what file extensions capistrano task files should get?
.cap or .rake?

capistrano-rails: .rake only
capistrano-bundler: .cap only
capistrano-rvm: .rake only
capistrano-rbenv: .rake only
capistrano: .rake in lib/ - and .cap in spec/ - and .cap in the Capfile template

@leehambley
Capistrano member

Put mildly I don't care too much, because I have vim syntax setup for both of them in Ruby.

If we're going to settle on .cap we need to have syntax hints for common editors in the headers in my opinion. If we take .rake, then we're being a bit more honest about who we are, but also relying on editors to do the right thing.

If you put a 🔫 to my :godmode: and made me choose, I'd choose .cap with modelines for vim/emacs.

@rvalente
rvalente commented Jan 3, 2014

+1 for .cap with modelines

@Kriechi
Kriechi commented Jan 3, 2014

I can't find the issue, where we already discussed this a bit...

But I think I switched sides on this.
I think .rake would emphasize that Capistrano is "just" a collection of Rake tasks - which might decrease dumb questions on how things work...

Would be nice to settle on one extensions and change all files accordingly.
just my 2 cents

@kirs
Capistrano member
kirs commented Jan 3, 2014

I think .rake would emphasize that Capistrano is "just" a collection of Rake tasks - which might decrease dumb questions on how things work...

Agree. I'm for .rake and against .cap.

@kirs
Capistrano member
kirs commented Jan 3, 2014

Why do we even need a special file extension for a usual ruby gem?
This will break code statistics, add more dump questions and break highlight in most of the editors.

@leehambley
Capistrano member
@leehambley
Capistrano member

Alright, I could agree with .rake (with or without modelines too). See also Bikeshedding

@billydavies billydavies added a commit to billydavies/capistrano that referenced this issue Jan 6, 2014
@kirs kirs Capistrano 3.1 post_install_message #813 5290c35
@ev0rtex
ev0rtex commented Jan 10, 2014

I'm fairly new to Capistrano and I'm curious what the timeline is for the 3.1 release. As best I can tell this is the only remaining issue for the milestone. I'd like to go ahead and use the 3.1 version as I'm starting my configuration but others on my team aren't comfortable using an unreleased version, hence my interest.

@leehambley leehambley closed this Jan 27, 2014
@leehambley
Capistrano member

@ev0rtex hopefully you caught the release a couple of weeks ago, if not please feel free to follow @capistranorb at Twitter for release announcements. We underwent some core team changes this time around, and had a few hiccups getting the release out, but that won't be typical, we hope!

@chengguangnan chengguangnan pushed a commit to chengguangnan/capistrano2 that referenced this issue Jun 20, 2014
Cheng Guangnan Merge branch 'master' into legacy-v2
* master: (256 commits)
  🐼 857: Load tasks from the deploy.rb
  🐼 Fixed failed tests
  Fixes capistrano#863
  bump SSHKit dependency
  A bit more structure to 3.1 release CHANGELOG * Highlight breaking changes * Mention @Kriechi 's help
  Cleaning up signing_key in gem spec
  Capistrano 3.1 post_install_message #813
  Documented deploy.rb.erb template to show what the default values are
  remove rails_env from stage template
  Add Ruby 2.1.0 to .travis.yml
  ✂️ trailing whitespace
  Lock config file by default
  Prepare for 3.1 release
  Don't set enforce_available_locales for older version of i18n.
  Set I18n.enforce_available_locales=true to fix deprecation warning.
  Use an SCM object with a pluggable strategy
  Add ability to filter tasks to specific servers (host filtering).
  Update CHANGELOG.md
  Allow roles to be fetched with an array
  Update CHANGELOG.md
  ...
153bc1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.