Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

make deploy:cleanup work with multi-host configuration #107

Merged
merged 1 commit into from Sep 24, 2011

Conversation

Projects
None yet
4 participants
Contributor

philrosenstein commented Sep 24, 2011

as per #89 (comment)

@leehambley leehambley added a commit that referenced this pull request Sep 24, 2011

@leehambley leehambley Merge pull request #107 from philrosenstein/master
Make deploy:cleanup work more reliably with multi-host configuration.
77663c5

@leehambley leehambley merged commit 77663c5 into capistrano:master Sep 24, 2011

Contributor

cgriego commented Oct 10, 2011

Why was the :roles option added to this task? We have custom roles with our app code that now are not cleaned. If you have custom roles that do not have app code, then you should be using the :no_release => true option on the server/role definition.

Contributor

ppg commented Oct 13, 2011

I agree with cgriego. The easiest example is that of a background role for processing jobs. The common case would be to intend to deploy and clean releases to that role/machine as it will need to execute code there also. With this change my background role will never be cleaned up and there's no way for me to change that configuration. If i have a role that doesn't need my code base (such as :im) then I should be using :no_release, which already skips deploy and cleanup; is there something missing from that functionality?

Thanks,
\Peter

Contributor

philrosenstein commented Oct 14, 2011

have taken :roles back out of :cleanup task #112 (sorry for the confusion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment