Allow to set logger level in initialization #223

Merged
merged 0 commits into from Jul 26, 2012

Conversation

Projects
None yet
3 participants
@MasterLambaster
Contributor

MasterLambaster commented Jun 6, 2012

Minor improvement to set log level in logger setup. Default level is still Capistrano::Logger::IMPORTANT

logger = Capistrano::Logger.new(:level => Capistrano::Logger::INFO)
logger.level #=> 1
@leehambley

This comment has been minimized.

Show comment Hide comment
@leehambley

leehambley Jun 6, 2012

Member

@MasterLambaster any chance you can test for this? I wouldn't like to break it when working in this area.

Member

leehambley commented Jun 6, 2012

@MasterLambaster any chance you can test for this? I wouldn't like to break it when working in this area.

@MasterLambaster

This comment has been minimized.

Show comment Hide comment
@MasterLambaster

MasterLambaster Jun 6, 2012

Contributor

@leehambley tests are included and passed(whole suite) on my side, the default behavior has not been changed. I don't know what other tests I can provide.

Contributor

MasterLambaster commented Jun 6, 2012

@leehambley tests are included and passed(whole suite) on my side, the default behavior has not been changed. I don't know what other tests I can provide.

@leehambley

This comment has been minimized.

Show comment Hide comment
@leehambley

leehambley Jun 6, 2012

Member

@MasterLambaster Sorry, saw your other pull request without tests, assumed the same here. Thanks.

Member

leehambley commented Jun 6, 2012

@MasterLambaster Sorry, saw your other pull request without tests, assumed the same here. Thanks.

carsomyr added a commit that referenced this pull request Jul 26, 2012

Merge pull request #223 from MasterLambaster/pull-3
Allow to set logger level in initialization

@carsomyr carsomyr merged commit fc899aa into capistrano:master Jul 26, 2012

@carsomyr

This comment has been minimized.

Show comment Hide comment
@carsomyr

carsomyr Jul 26, 2012

Contributor

Thanks for the patch!

Contributor

carsomyr commented Jul 26, 2012

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment