Add a :ignore_dry_run option to run_locally #464

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

yesmeck commented May 6, 2013

run_locally will not run command git ls-remote actually with dry-run flag,
so that query_revision can not get the excpected result and cause
error.

yesmeck closed this May 6, 2013

yesmeck reopened this May 6, 2013

@yesmeck yesmeck Add a :ignore_dry_run option to run_locally
`run_locally` will not run command `git ls-remote` actually with dry-run flag,
so that `query_revision` can not get the excpected result and cause
error.
33dfa10

yesmeck closed this Jun 12, 2013

@yesmeck - I was thinking about making a new PR to address this bug. I know it was a year ago, but do you remember why you closed this?

yesmeck commented Aug 25, 2014

@jmhbrown I have forgotten. :trollface:

Owner

leehambley commented Aug 25, 2014

I'm not keen on this at all. Please stop using run_locally, there is almost never a good reason to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment