Skip to content

Compare servers by user, hostname and port #916

Merged
merged 1 commit into from Feb 5, 2014

2 participants

@ShPakvel
ShPakvel commented Feb 2, 2014

To check if servers match compare them by
user, hostname and port.

When servers match is checked just by hostname and port
there is no way to access to the same server with different users
to execute special actions allowed for specific users.

There are workarounds to do it. But I think it should be done in standard way
through matching/comparing servers by 'user@hostname:port'.

I have found previous merged pull request with similar problem (about port):
#801
and solved my issue in similar way.

@ShPakvel ShPakvel Compare servers by user, hostname and port
To check if servers match compare them by
user, hostname and port.
0bee4f6
@leehambley
Capistrano member

Good call, I'll review this more properly later, but first glance looks good. Thanks for sticking to the CONTRIBUTING guidelines!

@ShPakvel
ShPakvel commented Feb 3, 2014

Thanks, Lee.
I hope it do not take you a lot of time.

@leehambley leehambley merged commit 456106e into capistrano:master Feb 5, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.