New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare servers by user, hostname and port #916

Merged
merged 1 commit into from Feb 5, 2014

Conversation

Projects
None yet
2 participants
@ShPakvel
Contributor

ShPakvel commented Feb 2, 2014

To check if servers match compare them by
user, hostname and port.

When servers match is checked just by hostname and port
there is no way to access to the same server with different users
to execute special actions allowed for specific users.

There are workarounds to do it. But I think it should be done in standard way
through matching/comparing servers by 'user@hostname:port'.

I have found previous merged pull request with similar problem (about port):
#801
and solved my issue in similar way.

Compare servers by user, hostname and port
To check if servers match compare them by
user, hostname and port.
@leehambley

This comment has been minimized.

Show comment
Hide comment
@leehambley

leehambley Feb 3, 2014

Member

Good call, I'll review this more properly later, but first glance looks good. Thanks for sticking to the CONTRIBUTING guidelines!

Member

leehambley commented Feb 3, 2014

Good call, I'll review this more properly later, but first glance looks good. Thanks for sticking to the CONTRIBUTING guidelines!

@ShPakvel

This comment has been minimized.

Show comment
Hide comment
@ShPakvel

ShPakvel Feb 3, 2014

Contributor

Thanks, Lee.
I hope it do not take you a lot of time.

Contributor

ShPakvel commented Feb 3, 2014

Thanks, Lee.
I hope it do not take you a lot of time.

leehambley added a commit that referenced this pull request Feb 5, 2014

Merge pull request #916 from ShPakvel/bugfix_users_for_the_same_host
Compare servers by user, hostname and port

@leehambley leehambley merged commit 456106e into capistrano:master Feb 5, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment